Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@vue/compat TS shim needs export {} to work properly #12

Closed
snoozbuster opened this issue May 17, 2022 · 0 comments · Fixed by #13
Closed

@vue/compat TS shim needs export {} to work properly #12

snoozbuster opened this issue May 17, 2022 · 0 comments · Fixed by #13

Comments

@snoozbuster
Copy link
Contributor

In the migration build steps, the typescript shim that's provided only works if there is an import or export at the top level of the file it's placed in, otherwise it doesn't cause TS to see the export * from '@vue/runtime-dom'. There is a relevant sentence in the Vue 3 docs about type augmentation vs type overwriting, which appears to be what's happening here.

Jinjiang pushed a commit that referenced this issue May 1, 2023
* feat: Ukrainian language

* feat: Migration build

* feat: Recommendations

* feat: Links, breaking changes page

* feat: global api

* fix: #9

* fix: #10 v-model

* #21 translate attr imcludes class and style

* #20 Translate: listeners are removed

* Update src/uk/breaking-changes/listeners-removed.md

* Update src/uk/breaking-changes/listeners-removed.md

* Update src/uk/breaking-changes/listeners-removed.md

* Update src/uk/breaking-changes/listeners-removed.md

* #19 Translate: Slots unification

* #18 Translate: render function API

* #28 Translate: PropsData

* #27 Translate:

* #27 Translate:

* #26 Translate: inline-template attribute

* #25 Translate: filters

* Update src/uk/breaking-changes/filters.md

* #24 Translate: events API

* #23 Translate: keycode modifiers

* Update src/uk/breaking-changes/keycode-modifiers.md

* Translate: custom elements interop

* Translate: custom directives #30

* Update src/uk/breaking-changes/custom-directives.md

Co-authored-by: Nazar Niphone <74293442+nazar1ua@users.noreply.github.com>

* Update src/uk/breaking-changes/custom-directives.md

Co-authored-by: Nazar Niphone <74293442+nazar1ua@users.noreply.github.com>

* Update src/uk/breaking-changes/custom-directives.md

Co-authored-by: Nazar Niphone <74293442+nazar1ua@users.noreply.github.com>

* Update src/uk/breaking-changes/custom-directives.md

Co-authored-by: Nazar Niphone <74293442+nazar1ua@users.noreply.github.com>

* translation improvements

* translate: key Attribute #11

* translate: v-bind merge behavior #13

* translate: v-if vs. v-for precedence #12

* translate: v-on.native modifier removed #14

* translate: title fix #14

* translate: functional components #15

* translate: async components #16

* translate: emits option #17

* translate: attribute coercion behavior #29

* translate: mount changes #32

* translate: props default this access #33

* translate: transition class change #34

* translate: transition as root #35

* translate: transition group root element #36

* translate: vnode lifecycle events #37

* translate: watch on arrays #38

* Update src/uk/breaking-changes/v-if-v-for.md

Co-authored-by: Olesya Kogivchak <lesya.kogivchak@gmail.com>

* Update src/uk/breaking-changes/v-if-v-for.md

Co-authored-by: Olesya Kogivchak <lesya.kogivchak@gmail.com>

* Update src/uk/breaking-changes/key-attribute.md

Co-authored-by: Olesya Kogivchak <lesya.kogivchak@gmail.com>

* Translate: data option

---------

Co-authored-by: olesyakogivchak <olesya.kohivchak@evry.com>
Co-authored-by: Nazar Niphone <74293442+nazar1ua@users.noreply.github.com>
Co-authored-by: Max Druzhinin <6406412+maxdzin@users.noreply.github.com>
Co-authored-by: Olesya Kogivchak <lesya.kogivchak@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant