Change vnode-lifecycle-events prefix back to vnode-
#16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for eager-kowalevski-41f498 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Jinjiang
pushed a commit
that referenced
this pull request
May 1, 2023
* feat: Ukrainian language * feat: Migration build * feat: Recommendations * feat: Links, breaking changes page * feat: global api * fix: #9 * fix: #10 v-model * #21 translate attr imcludes class and style * #20 Translate: listeners are removed * Update src/uk/breaking-changes/listeners-removed.md * Update src/uk/breaking-changes/listeners-removed.md * Update src/uk/breaking-changes/listeners-removed.md * Update src/uk/breaking-changes/listeners-removed.md * #19 Translate: Slots unification * #18 Translate: render function API * #28 Translate: PropsData * #27 Translate: * #27 Translate: * #26 Translate: inline-template attribute * #25 Translate: filters * Update src/uk/breaking-changes/filters.md * #24 Translate: events API * #23 Translate: keycode modifiers * Update src/uk/breaking-changes/keycode-modifiers.md * Translate: custom elements interop * Translate: custom directives #30 * Update src/uk/breaking-changes/custom-directives.md Co-authored-by: Nazar Niphone <74293442+nazar1ua@users.noreply.github.com> * Update src/uk/breaking-changes/custom-directives.md Co-authored-by: Nazar Niphone <74293442+nazar1ua@users.noreply.github.com> * Update src/uk/breaking-changes/custom-directives.md Co-authored-by: Nazar Niphone <74293442+nazar1ua@users.noreply.github.com> * Update src/uk/breaking-changes/custom-directives.md Co-authored-by: Nazar Niphone <74293442+nazar1ua@users.noreply.github.com> * translation improvements * translate: key Attribute #11 * translate: v-bind merge behavior #13 * translate: v-if vs. v-for precedence #12 * translate: v-on.native modifier removed #14 * translate: title fix #14 * translate: functional components #15 * translate: async components #16 * translate: emits option #17 * translate: attribute coercion behavior #29 * translate: mount changes #32 * translate: props default this access #33 * translate: transition class change #34 * translate: transition as root #35 * translate: transition group root element #36 * translate: vnode lifecycle events #37 * translate: watch on arrays #38 * Update src/uk/breaking-changes/v-if-v-for.md Co-authored-by: Olesya Kogivchak <lesya.kogivchak@gmail.com> * Update src/uk/breaking-changes/v-if-v-for.md Co-authored-by: Olesya Kogivchak <lesya.kogivchak@gmail.com> * Update src/uk/breaking-changes/key-attribute.md Co-authored-by: Olesya Kogivchak <lesya.kogivchak@gmail.com> * Translate: data option --------- Co-authored-by: olesyakogivchak <olesya.kohivchak@evry.com> Co-authored-by: Nazar Niphone <74293442+nazar1ua@users.noreply.github.com> Co-authored-by: Max Druzhinin <6406412+maxdzin@users.noreply.github.com> Co-authored-by: Olesya Kogivchak <lesya.kogivchak@gmail.com>
|
Thank you for your contributing! In Vue 3.4, the So we have to close your PR. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current documentation is inconsistent with the @vue/compat warning which makes things a bit confusing.
Docs currently say the new prefix is
vue:, while the warning says it'svnode-The most info I could find on this is here #5 (review)
To fix the inconsistency, I think the docs should be changed back to
vnode-(rather than the warnings updated tovue:),since there's a lot of 3rd party material for migrating (not to mention, people's experiences) that can't be updated so easily.
To be clear, in my opinion it was a mistake to change docs from
vnode-tovue:.Such a fundamental change to the documented breaking changes after the community is already migrating, creates fragmentation and confusion. It happened today with a colleague.
In other words, I think we should try to avoid making "breaking changes" to the documented breaking changes.
/cc @skirtles-code