Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build output ES6 module version #328

Merged
merged 1 commit into from May 8, 2019
Merged

Build output ES6 module version #328

merged 1 commit into from May 8, 2019

Conversation

gmoneh
Copy link
Contributor

@gmoneh gmoneh commented May 8, 2019

This proposed change adds a ES6 module output to the build, for use with ES6 module-aware bundlers such as rollup.

Copy link
Member

@ktsn ktsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
Please revert the changes under dist/ directory since it should be updated when releasing a new version.

@gmoneh
Copy link
Contributor Author

gmoneh commented May 8, 2019

Changes under dist/ have been reverted.

Copy link
Member

@ktsn ktsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ktsn ktsn merged commit b396d92 into vuejs:master May 8, 2019
@vue-bot
Copy link

vue-bot commented May 8, 2019

Hey @gmoneh, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚

nevilm-lt pushed a commit to nevilm-lt/vue-class-component that referenced this pull request Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants