Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend package on vue config overwrite existing settings #1053

Closed
Akryum opened this issue Mar 29, 2018 · 1 comment
Closed

Extend package on vue config overwrite existing settings #1053

Akryum opened this issue Mar 29, 2018 · 1 comment
Labels
bug

Comments

@Akryum
Copy link
Member

Akryum commented Mar 29, 2018 •
edited
Loading

Using api.extendPackage({ vue: { pluginOptions: { /* ... */ } } }) (example) overrides the existing settings.

How to reproduce

  1. Add apollo plugin with for example auto-mocking
  2. Add i18n plugin with SFC option

What is expected

The new pluginOptions.enableInSFC option is added to the existing ones.

What is actually happening

The pluginOptions is replaced and contains only the new enableInSFC option.

image
@Akryum Akryum added the bug label Mar 29, 2018
@Akryum
Copy link
Member Author

Akryum commented Mar 29, 2018

I believe this part should be modified.

dhensche added a commit to dhensche/vue-cli that referenced this issue Apr 3, 2018
@dhensche
fix: deep merge objects when extending package.json via plugins (vuej…
ccc241d 
…s#1053)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Akryum