Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .mjs files as transpileable files #3485

Merged
merged 1 commit into from
Feb 28, 2019
Merged

Add .mjs files as transpileable files #3485

merged 1 commit into from
Feb 28, 2019

Conversation

mnugter
Copy link
Contributor

@mnugter mnugter commented Feb 20, 2019

I'm not 100% sure but the option transpileDependencies in vue.config.js did not work for dependencies that use .mjs files. This small regex change fixes that problem.

@haoqunjiang haoqunjiang changed the base branch from dev to february-update February 21, 2019 07:31
@haoqunjiang haoqunjiang changed the base branch from february-update to dev February 21, 2019 07:31
@mnugter
Copy link
Contributor Author

mnugter commented Feb 22, 2019

Failed CI AppVeyor seems a random failure on a test that took too long?

@haoqunjiang haoqunjiang merged commit 8562d3e into vuejs:dev Feb 28, 2019
@mnugter mnugter deleted the support-mjs branch February 28, 2019 07:14
@kuoruan
Copy link

kuoruan commented Nov 22, 2022

@sodatea What about the cjs files? can it be included in the regex? /\.(c|m)?jsx?$/

When I transpile some lib with cjs files, I found it can not go through babel-loader.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants