fix(typescript): add assertVersion to typescript since it relies on router, fixes #4291 #4318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haoqunjiang
requested changes
Jul 19, 2019
There was a problem hiding this comment.
I'm sorry but this doesn't work.
The bug happens when typescript plugin is added without router plugin being present.
It is because the Home.vue template extends cli-plugin-router/src/views/Home.vue and the parent file does not exist in that case. In the past, the parent template resided in cli-service package so it was never a problem.
IMO, a fix can be landed in GeneratorAPI, the parent template should be loaded only after the when condition being evaluated as truthy.
|
Closed in favor of #4330 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.