Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference mochapack in README #4651

Closed
wants to merge 2 commits into from
Closed

Reference mochapack in README #4651

wants to merge 2 commits into from

Conversation

JamesMcMahon
Copy link
Contributor

@JamesMcMahon JamesMcMahon commented Oct 5, 2019

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

As of e08603b, this plugin uses mochapack instead of mocha-webpack. Updated the README to reflect this.

The Pull Request Template says to submit this PR to master, as it is a doc change, but this change currently doesn't exist on master, so submitting to dev instead. EDIT: Just noticed this change is on next, rebased on to the branch.

sodatea and others added 2 commits October 4, 2019 23:28
As of e08603b, this plugin uses mochapack instead of mocha-webpack. Updated the README to reflect this.
@JamesMcMahon JamesMcMahon changed the base branch from dev to next October 5, 2019 22:51
@JamesMcMahon
Copy link
Contributor Author

Closing in favor of #4652.

Re-basing lead to some weirdness.

@JamesMcMahon JamesMcMahon deleted the patch-1 branch October 6, 2019 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants