Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Reference mochapack in README (#4652) #4652

Merged
merged 1 commit into from Oct 6, 2019

Conversation

@JamesMcMahon
Copy link
Contributor

commented Oct 5, 2019

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:
As of e08603b, this plugin uses mochapack instead of mocha-webpack. Updated the README to reflect this.

As of e08603b, this plugin uses mochapack instead of mocha-webpack. Updated the README to reflect this.
@JamesMcMahon JamesMcMahon referenced this pull request Oct 5, 2019
2 of 9 tasks complete
@JamesMcMahon JamesMcMahon changed the title Reference mochapack in README docs: Reference mochapack in README Oct 5, 2019
@JamesMcMahon

This comment has been minimized.

Copy link
Contributor Author

commented Oct 5, 2019

👋 Hi, first PR to this project from me. I think this belongs in next, but if it doesn't let me know and I can point it at dev or whatever branch you need.

@sodatea
sodatea approved these changes Oct 6, 2019
@sodatea sodatea changed the title docs: Reference mochapack in README docs: Reference mochapack in README (#4652) [ci skip] Oct 6, 2019
@sodatea sodatea merged commit b218dfe into vuejs:next Oct 6, 2019
8 checks passed
8 checks passed
ci/circleci: cli-ui Your tests passed on CircleCI!
Details
ci/circleci: group-1 Your tests passed on CircleCI!
Details
ci/circleci: group-2 Your tests passed on CircleCI!
Details
ci/circleci: group-3 Your tests passed on CircleCI!
Details
ci/circleci: group-4 Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
deploy/netlify Deploy preview ready!
Details
@sodatea sodatea changed the title docs: Reference mochapack in README (#4652) [ci skip] docs: Reference mochapack in README (#4652) Oct 6, 2019
@vue-bot

This comment has been minimized.

Copy link

commented Oct 6, 2019

Hey @JamesMcMahon, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚

@JamesMcMahon JamesMcMahon deleted the JamesMcMahon:patch-3 branch Oct 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.