Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip checking git gpgSign config #5869

Merged
merged 1 commit into from Sep 10, 2020
Merged

fix: skip checking git gpgSign config #5869

merged 1 commit into from Sep 10, 2020

Conversation

@sodatea
Copy link
Member

@sodatea sodatea commented Sep 10, 2020

Fix the issue described at #5823 (comment)

This simplifies the logic, thus less error-prone.
The error message is still correct anyway.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

Fix the issue described at #5823 (comment)

This simplifies the logic, thus less error-prone.
The error message is still correct anyway.
@sodatea sodatea merged commit 6409363 into vuejs:dev Sep 10, 2020
6 of 7 checks passed
6 of 7 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
ci/circleci: cli-ui Your tests passed on CircleCI!
Details
ci/circleci: group-1 Your tests passed on CircleCI!
Details
ci/circleci: group-2 Your tests passed on CircleCI!
Details
ci/circleci: group-3 Your tests passed on CircleCI!
Details
ci/circleci: group-4 Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
@sodatea sodatea deleted the sodatea:fix-gpg-sign branch Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant