Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cypress plugin stop error #7288

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

iriadp
Copy link

@iriadp iriadp commented Sep 5, 2022

When running tests with cypress plugin and Cypress 10, an exception is thrown when the stop() function is called to stop the server.
Changing method to close() doesn't throw any exception or warning and the server gets closed correctly.
#7230

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Iria Díaz Pérez and others added 2 commits September 5, 2022 10:07
@yifaneye
Copy link

@iriadp Thanks for your work!

@lucasportolima
Copy link

hey guys, any news about the new build of this fix ?

@nativanando
Copy link

Hi guys, any news about it?

@yrollam
Copy link

yrollam commented Oct 4, 2022

This is blocking out org from upgrading to cypress 10. Would we awesome if this fix got some attention.

@AlbinSahlbom
Copy link

Any update on when this could be fixed?
This is also blocking our company to upgrade to version 10

@AlbinSahlbom
Copy link

@yifaneye is there any timeline for this bug fix?

@daniel-bsci
Copy link

@AlbinSahlbom We've been waiting for this as well for several months. Gave up and switched to vite and it was surprisingly painless. Now we're on cypress 12 and as a bonus a much faster dev/build experience.

@nvspradeep
Copy link

@iriadp can you request reviewers with write accesss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants