Babel bug: `.inputSourceMap must be a boolean, object, or undefined` & `filename` is undefined error fix #138

rumanHuq · 2018-12-26T23:25:07Z

This is my first pull request ever just FYI :) So, Please go easy on me.

Current @babel/core requires either boolean, or object in inputSourceMap. So putting empty string will throw error (lib/compilers/typescript-compiler.js : 14)

While using @babel/preset-typescript babel.transform requires a filename(lib/compilers/babel-compiler.js: 20), even though the typedef for @babel/core says it's optional. I have given the defaultname "unknown" mentioned in the @types/babel-core file

Ran test to make sure it didn't break anything

line 14. import vue file containing <script lang="ts"> in tests fails due to "node_modules/@babel/core/lib/config/validation/option-assertions.js:110:11)" line 18: Even though filename is optional as of their typedef() not providing "filename" throws an error in "node_modules/@babel/core/lib/config/config-chain.js:431:11" line 20. It would be nice to upgrade the plugin as well

eddyerburgh

Thanks for the PR, it looks good :)

Can you add a new test that reproduces the issue that's fixed by this change?

rumanHuq · 2018-12-27T16:39:11Z

Can you please elaborate the steps? As in how/what should I test?

eddyerburgh · 2018-12-27T16:49:29Z

You could create a test that reproduces the issue.

You can see a test here—https://github.com/vuejs/vue-jest/blob/v3/test/Babel.spec.js#L98. It writes plugins to the .babelrc file, then calls jestVue.process. In your case, you would add @babel/preset-typescript to the .babelrc, and then make sure it doesn't error by calling vueJest.process (assuming that it does at the moment). Let me know if you have any other questions

eddyerburgh · 2018-12-29T10:57:16Z

lib/compilers/babel-compiler.js

@@ -1,4 +1,4 @@
-const babel = require('babel-core')
+const babel = require('@babel/core')


This makes this PR a breaking change, can you keep the old babel-core in this PR? You can use babel-core bridge (https://github.com/babel/babel-bridge) if you need functionality of babel 7.

Reverted back.

rumanHuq · 2018-12-29T15:30:05Z

Alright, so it was not as easy as I thought it would be. It has to do with babel 7, and the current vue-jest is transpiled with babel 6. Here are the summary of what has been done:

All the related code is upgraded to comply with babel changes.
A test case is setup, where the issue is reproduced.

rumanHuq · 2018-12-29T15:39:02Z

#122 should be fixed with this one, along with some other babel 7 related issues which are faced by users

rumanHuq

bounced back to babel 6 as per review

rumanHuq · 2018-12-29T15:48:06Z

lib/compilers/babel-compiler.js

@@ -1,4 +1,4 @@
-const babel = require('babel-core')
+const babel = require('@babel/core')


Reverted back.

eddyerburgh · 2018-12-29T19:36:33Z

lib/compilers/babel-compiler.js

@@ -23,7 +23,16 @@ module.exports = function compileBabel (scriptContent, inputSourceMap, inlineCon
    babelOptions = Object.assign(babelOptions, babelOverWrites)
  }

-  const res = babel.transform(scriptContent, babelOptions)


Can you revert to the previous code? babel.transform will use babel 6 transform if babel-core is babel 6, and babel 7 if babel-core is @bridge.

I reverted back to original code, except this chunk

This to only reproduce the issue in test

Now the snapshot test is failing, can you check the codes for assesment

rumanHuq · 2019-01-09T15:09:12Z

@eddyerburgh Test provided, snapshot failing. Please check, My test included babel 7, which is why there is snapshot missmatch.

DotCoyote · 2019-01-30T07:36:47Z

For anyone who encounters this error too: After several hours I found a fix/workaround for this problem:

tsconfig.json:

{
  "compilerOptions": {
    [...]
    "allowSyntheticDefaultImports": true,

This is the important setting.

kermorgant · 2019-02-04T09:05:39Z

Same error happened to me, and in my case, I solved it by adding "sourceMap": true in tsconfig.json

eddyerburgh · 2019-02-05T19:44:52Z

lib/process.js

  const vueJestConfig = getVueJestConfig(jestConfig)

  var parts = vueCompiler.parseComponent(src, { pad: true })

  if (parts.script && parts.script.src) {
    parts.script.content = fs.readFileSync(join(filePath, '..', parts.script.src), 'utf8')
  }
-
-  const result = processScript(parts.script, vueJestConfig, filePath)
+  const result = processScript(parts.script, vueJestConfig, filePath, babelTestObj)


Can you please remove the babelTestObj from the code

eddyerburgh · 2019-02-05T19:46:04Z

test/Babel-typescript.spec.js

+  cache.flushAll()
+  clearModule.all()
+})
+test('babel 7 configuration expects filename [default: "unknown"] to compile', () => {


In this case, since it's a small change and difficult to test, you can remove these tests and we'll leave it untested

eddyerburgh · 2019-02-05T19:49:02Z

So since the changes to code are relatively small, and we'll realase v4 soon, it's OK to add this code without any tests. Can you please put an inline comment above the code to add the filename, and above the ternary where you assign the input map, to describe why you made the changes?

eddyerburgh · 2019-02-08T06:10:21Z

lib/compilers/babel-compiler.js

@@ -17,11 +17,15 @@ module.exports = function compileBabel (scriptContent, inputSourceMap, inlineCon
  }

  const babelOptions = Object.assign(sourceMapOptions, babelConfig)
+  if (!babelOptions.filename) babelOptions.filename = 'unknown'


Can you remove this line please

eddyerburgh

Thanks for the changes :)

eddyerburgh · 2019-02-08T06:45:14Z

This has been released in 3.0.3 👍

mattgrande · 2019-02-08T16:36:49Z

@eddyerburgh - I'm not seeing 3.0.3 on NPM yet. Is there a delay on NPM's side?

eddyerburgh · 2019-02-08T16:45:19Z

No sorry, the publish had failed on my end. Just published now

rumanHuq added 5 commits December 27, 2018 01:17

lint

472b0f3

leave inlineBabelConfig as is, put 'filename' in babel-compiler

7df626b

revert babel inlineplugin

da0f256

package.json as is

53f0bf0

eddyerburgh requested changes Dec 27, 2018

View reviewed changes

rumanHuq added 3 commits December 29, 2018 01:44

WIP, babel upgrade, coffeescript fails

87b84cf

babel upgrade works across platforms

28e085f

bump down eslint

fbf4784

eddyerburgh reviewed Dec 29, 2018

View reviewed changes

create test covering babel upgrade

6fc24fc

rumanHuq changed the title ~~fixes for @babel/preset-typescript users~~ Babel Upgrade fix breaking changes Dec 29, 2018

rumanHuq added 4 commits December 29, 2018 17:47

@babel/core to babel-core

3c67a8f

bumpdown "@babel/env" to "env" in test

5db4de2

remove @babel/transform-commonjs..

40a0ce1

redundant prop remove

9626b72

rumanHuq commented Dec 29, 2018

View reviewed changes

rumanHuq added 3 commits December 29, 2018 21:01

change compatible to babel 6 and 7

58a436f

put some comments

bcb2bbb

++

b6ecf3d

eddyerburgh reviewed Dec 29, 2018

View reviewed changes

rumanHuq added 2 commits December 29, 2018 23:18

revert babel-compile

8cc0cb2

revert babel-compile

2f73249

This was referenced Jan 3, 2019

<script lang="ts"> not working with babel 7, @babel/preset-typescript #122

Closed

vue + jest + typescript: Unexpected token import #134

Closed

rumanHuq closed this Jan 4, 2019

rumanHuq deleted the patch-2 branch January 4, 2019 13:37

rumanHuq restored the patch-2 branch January 9, 2019 12:28

WIP

db1c7b5

rumanHuq reopened this Jan 9, 2019

rumanHuq added 3 commits January 9, 2019 16:04

wip

15b1d29

pass babelTest obj to check filename

7d4b797

update package

cd370d1

eslint bump down

473221c

rumanHuq changed the title ~~Babel Upgrade fix breaking changes~~ Babel bug: .inputSourceMap must be a boolean, object, or undefined Jan 9, 2019

rumanHuq changed the title ~~Babel bug: .inputSourceMap must be a boolean, object, or undefined~~ Babel bug: .inputSourceMap must be a boolean, object, or undefined & filename is undefined error fix Jan 9, 2019

eddyerburgh reviewed Feb 5, 2019

View reviewed changes

rumanHuq added 4 commits February 6, 2019 13:23

fix based on last review

9dfc943

revert to original

f399493

delete test

d1c1945

rm , cleanup

6954872

eddyerburgh reviewed Feb 8, 2019

View reviewed changes

eddyerburgh added 3 commits February 8, 2019 06:16

Remove duplicated line:

132ae7a

Revert yarn.lock

c007961

Regenerate yarn lock

ec33f40

eddyerburgh approved these changes Feb 8, 2019

View reviewed changes

eddyerburgh merged commit c44e618 into vuejs:v3 Feb 8, 2019

rumanHuq deleted the patch-2 branch February 9, 2019 07:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Babel bug: `.inputSourceMap must be a boolean, object, or undefined` & `filename` is undefined error fix #138

Babel bug: `.inputSourceMap must be a boolean, object, or undefined` & `filename` is undefined error fix #138

rumanHuq commented Dec 26, 2018 •

edited

eddyerburgh left a comment

rumanHuq commented Dec 27, 2018

eddyerburgh commented Dec 27, 2018

eddyerburgh Dec 29, 2018

rumanHuq Dec 29, 2018

rumanHuq commented Dec 29, 2018 •

edited

rumanHuq commented Dec 29, 2018

rumanHuq left a comment

rumanHuq Dec 29, 2018

eddyerburgh Dec 29, 2018

rumanHuq Dec 29, 2018

rumanHuq commented Jan 9, 2019

DotCoyote commented Jan 30, 2019

kermorgant commented Feb 4, 2019

eddyerburgh Feb 5, 2019

rumanHuq Feb 6, 2019

eddyerburgh Feb 5, 2019

rumanHuq Feb 6, 2019

eddyerburgh commented Feb 5, 2019

eddyerburgh Feb 8, 2019

eddyerburgh left a comment

eddyerburgh commented Feb 8, 2019

mattgrande commented Feb 8, 2019

eddyerburgh commented Feb 8, 2019

		@@ -1,4 +1,4 @@
		const babel = require('babel-core')
		const babel = require('@babel/core')

Babel bug: .inputSourceMap must be a boolean, object, or undefined & filename is undefined error fix #138

Babel bug: .inputSourceMap must be a boolean, object, or undefined & filename is undefined error fix #138

Conversation

rumanHuq commented Dec 26, 2018 • edited

eddyerburgh left a comment

Choose a reason for hiding this comment

rumanHuq commented Dec 27, 2018

eddyerburgh commented Dec 27, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rumanHuq commented Dec 29, 2018 • edited

rumanHuq commented Dec 29, 2018

rumanHuq left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rumanHuq commented Jan 9, 2019

DotCoyote commented Jan 30, 2019

kermorgant commented Feb 4, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eddyerburgh commented Feb 5, 2019

Choose a reason for hiding this comment

eddyerburgh left a comment

Choose a reason for hiding this comment

eddyerburgh commented Feb 8, 2019

mattgrande commented Feb 8, 2019

eddyerburgh commented Feb 8, 2019

Babel bug: `.inputSourceMap must be a boolean, object, or undefined` & `filename` is undefined error fix #138

Babel bug: `.inputSourceMap must be a boolean, object, or undefined` & `filename` is undefined error fix #138

rumanHuq commented Dec 26, 2018 •

edited

rumanHuq commented Dec 29, 2018 •

edited