fix(normalizeLocation): create a copy with named locations

Fix #2121
vuejs · Jul 7, 2018 · d5129a3 · d5129a3
1 parent 3cad567
commit d5129a3
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/src/util/location.js b/src/util/location.js
@@ -15,8 +15,10 @@ export function normalizeLocation (
 ): Location {
   let next: Location = typeof raw === 'string' ? { path: raw } : raw
   // named target
-  if (next.name || next._normalized) {
+  if (next._normalized) {
     return next
+  } else if (next.name) {
+    return extend({}, raw)
   }
 
   // relative params

diff --git a/test/unit/specs/location.spec.js b/test/unit/specs/location.spec.js
@@ -120,5 +120,14 @@ describe('Location utils', () => {
       const loc2 = normalizeLocation(loc1)
       expect(loc1).toBe(loc2)
     })
+
+    it('creates copies when not normalized', () => {
+      const l1 = { name: 'foo' }
+      expect(normalizeLocation(l1)).not.toBe(l1)
+      const l2 = { path: '/foo' }
+      expect(normalizeLocation(l2)).not.toBe(l2)
+      const l3 = { path: '/foo', query: { foo: 'foo' } }
+      expect(normalizeLocation(l3)).not.toBe(l3)
+    })
   })
 })