Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implicit params ({ name: 'sub-route' }) don't update when navigating between nested routes #2121

Closed
mudoo opened this issue Mar 22, 2018 · 7 comments · Fixed by mariazevedo88/hash-generator-js#5, tghelere/valorize-vidas#4, tghelere/DeliVuery#18, tghelere/dailymages#2 or tghelere/vuestore#4
Closed

implicit params ({ name: 'sub-route' }) don't update when navigating between nested routes #2121

mudoo opened this issue Mar 22, 2018 · 7 comments · Fixed by mariazevedo88/hash-generator-js#5, tghelere/valorize-vidas#4, tghelere/DeliVuery#18, tghelere/dailymages#2 or tghelere/vuestore#4
Labels
bug has PR has workaround

Comments

@mudoo
Copy link

mudoo commented Mar 22, 2018 •
edited
Loading

Version

3.0.1

Reproduction link

https://jsfiddle.net/67xnq5to/

Steps to reproduce

  1. click /foo/1/sub1
  2. click /foo/2/sub1
  3. click sub2

What is expected?

id==2

What is actually happening?

id is 1

like #1255
@mudoo mudoo changed the title dynamically params can't update <router-link> dynamically params can't update Mar 22, 2018
@posva

This comment has been minimized.

Sign in to view
@posva posva added the bug label Mar 23, 2018
@posva posva changed the title <router-link> dynamically params can't update implicit params ({ name: 'sub-route' }) don't update when navigating between nested routes Mar 23, 2018
@reinhardt1053
Copy link

Any workaround?

@posva posva mentioned this issue Apr 10, 2018
Closed
@posva
Copy link
Member

posva commented Jul 2, 2018 •
edited
Loading

@reinhardt1053 The workaround is explicitly passing the param:

const FooSub1 = {
  template: '<router-link :to="{name:\'sub2\', params: { id: $route.params.id}}">sub2</router-link>'
}

Sorry for the delay 😅

@jesusfreak3

This comment has been minimized.

Sign in to view
posva added a commit that referenced this issue Jul 7, 2018
@posva
fix(normalizeLocation): create a copy with named locations
d5129a3 
Fix #2121
@posva posva mentioned this issue Jul 7, 2018
Merged
@posva posva added the has PR label Jul 9, 2018
@vuejs vuejs deleted a comment from hlongjuice Aug 11, 2018
@rlfrahm
Copy link

rlfrahm commented Aug 25, 2018

Checkout this comment which mighttttt be your problem? #1255 (comment)

@econic

This comment has been minimized.

Sign in to view
@posva

This comment has been minimized.

Sign in to view
posva added a commit that referenced this issue Mar 28, 2019
@posva
fix(normalizeLocation): create a copy with named locations
97a05d6 
Fix #2121
posva added a commit that referenced this issue Mar 28, 2019
@posva
fix(normalizeLocation): create a copy with named locations (#2286)
53cce99 
* fix(normalizeLocation): create a copy with non normalized named locations

Fix #2121

* test(nested-routes): add e2e test for implicit params

* chore(lint): fix
This was referenced Aug 29, 2019
Open
Open
Closed
Open
@tt9133github tt9133github mentioned this issue Sep 18, 2019
Open
@snyk-bot snyk-bot mentioned this issue Sep 22, 2019
Merged
This was referenced Sep 22, 2019
Open
Open
@snyk-bot snyk-bot mentioned this issue Oct 1, 2019
Open
This was referenced Oct 26, 2019
Open
Open
This was referenced Jan 20, 2020
Merged
Merged
Merged
Merged
This was referenced Feb 5, 2020
Merged
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug has PR has workaround
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Snyk] Upgrade vue-router from 3.0.2 to 3.1.3 mariazevedo88/hash-generator-js
[Snyk] Upgrade vue-router from 3.0.2 to 3.1.3 tghelere/valorize-vidas
[Snyk] Upgrade vue-router from 3.0.1 to 3.1.3 tghelere/DeliVuery
[Snyk] Upgrade vue-router from 3.0.1 to 3.1.3 tghelere/dailymages
[Snyk] Upgrade vue-router from 3.0.1 to 3.1.3 tghelere/vuestore
[Snyk] Upgrade vue-router from 3.0.2 to 3.1.3 estafette/estafette-ci-web
[Snyk] Upgrade vue-router from 3.0.2 to 3.1.4 santosomar/linux_kernel_cves
[Snyk] Upgrade vue-router from 3.0.2 to 3.1.2 iliutastoica/30-days-of-vue
[Snyk] Upgrade vue-router from 3.0.1 to 3.1.2 iliutastoica/vue-blog-demo
[Snyk] Upgrade vue-router from 3.0.2 to 3.1.2 iliutastoica/greekdev-template-vue-spa
6 participants
@reinhardt1053 @posva @mudoo @jesusfreak3 @econic @rlfrahm