Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example server configurations only work for single page apps #3537

Closed
korggy opened this issue Apr 28, 2021 · 2 comments
Closed

Example server configurations only work for single page apps #3537

korggy opened this issue Apr 28, 2021 · 2 comments

Comments

@korggy
Copy link

korggy commented Apr 28, 2021

Version

3.5.1

Reproduction link

https://router.vuejs.org/guide/essentials/history-mode.html#example-server-configurations

Steps to reproduce

The example server configurations in the Vue Router documentation only work for single page apps, not multipage apps.

What is expected?

The server should return the correct html content for the specific page requested from a multipage app.

What is actually happening?

The server returns unexpected and incorrect content when the user tries to navigate to other pages in a multipage app.


I recommend adding a note to the documentation warning that multipage apps may require more sophisticated server configuration. An example would be helpful, but not necessary.

@posva
Copy link
Member

posva commented May 2, 2021

This kind of issues would require directly a pull request, an issue doesn't seem to bring any guidance to anybody trying to contribute. I'm closing this in favour of a pull request with a suggestion that includes an example instead of saying things are come complicated and maybe some external links. But I'm not sure this kind of documentation has its place in the router docs in the first place

@posva posva closed this as completed May 2, 2021
@wparad
Copy link

wparad commented May 2, 2021

This kind of issues would require directly a pull request, an issue doesn't seem to bring any guidance to anybody trying to contribute. I'm closing this in favour of a pull request with a suggestion that includes an example instead of saying things are come complicated and maybe some external links. But I'm not sure this kind of documentation has its place in the router docs in the first place

I think the question we should be asking ourselves is: Is an example configuration for a multi-page app sufficiently complex, relevant, or interesting. If it is one of those then we should think about creating it. What's wrong with having an open issue to suggest that work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants