Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(router): prevent memory leaks by removing app references #2706

Merged
merged 15 commits into from
Apr 12, 2019
Merged

fix(router): prevent memory leaks by removing app references #2706

merged 15 commits into from
Apr 12, 2019

Commits on Apr 11, 2019

  1. fix(router): remove app from $router.apps array once app destroyed (F… 

    …ixes #2639)


Prevent destroyed apps from causing memory leak in `$router.apps` array.

Fixes #2639
    @tmorehouse @posva
    tmorehouse authored and posva committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    836c009 View commit details
    Browse the repository at this point in the history

  2. lint

    @tmorehouse @posva
    tmorehouse authored and posva committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    642e80d View commit details
    Browse the repository at this point in the history

  3. lint

    @tmorehouse @posva
    tmorehouse authored and posva committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    a8cd5af View commit details
    Browse the repository at this point in the history

  4. Update index.js

    @tmorehouse @posva
    tmorehouse authored and posva committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    ed1d5d0 View commit details
    Browse the repository at this point in the history

  5. better handling of last app destroyed 

    Prevents history listeners from being set up multiple times
    @tmorehouse @posva
    tmorehouse authored and posva committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    48b69fb View commit details
    Browse the repository at this point in the history

  6. add app destroy testing

    @tmorehouse @posva
    tmorehouse authored and posva committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    bca252b View commit details
    Browse the repository at this point in the history

  7. Update api.spec.js

    @tmorehouse @posva
    tmorehouse authored and posva committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    2696c10 View commit details
    Browse the repository at this point in the history

  8. Update api.spec.js

    @tmorehouse @posva
    tmorehouse authored and posva committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    fe214b2 View commit details
    Browse the repository at this point in the history

  9. Update api.spec.js

    @tmorehouse @posva
    tmorehouse authored and posva committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    87edd99 View commit details
    Browse the repository at this point in the history

  10. Update api.spec.js

    @tmorehouse @posva
    tmorehouse authored and posva committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    aa204e9 View commit details
    Browse the repository at this point in the history

  11. Update api.spec.js

    @tmorehouse @posva
    tmorehouse authored and posva committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    b540487 View commit details
    Browse the repository at this point in the history

  12. Update api.spec.js

    @tmorehouse @posva
    tmorehouse authored and posva committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    a31748e View commit details
    Browse the repository at this point in the history

  13. Update api.spec.js

    @tmorehouse @posva
    tmorehouse authored and posva committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    f49415e View commit details
    Browse the repository at this point in the history

  14. refactor: code review

    @posva
    posva committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    009736d View commit details
    Browse the repository at this point in the history

  15. refactor: remove unused code

    @posva
    posva committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    47c0920 View commit details
    Browse the repository at this point in the history