fix: allow plugins to be re-installed in localVue instance (fixes #406)…

… (#411)
vuejs · Feb 5, 2018 · 9381736 · 9381736
1 parent 91472e4
commit 9381736
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 0 deletions.
diff --git a/src/create-local-vue.js b/src/create-local-vue.js
@@ -32,6 +32,9 @@ function createLocalVue (): Component {
   instance.options._base = instance
 
   // compat for vue-router < 2.7.1 where it does not allow multiple installs
+  if (instance._installedPlugins && instance._installedPlugins.length) {
+    instance._installedPlugins.length = 0
+  }
   const use = instance.use
   instance.use = (plugin, ...rest) => {
     if (plugin.installed === true) {

diff --git a/test/specs/create-local-vue.spec.js b/test/specs/create-local-vue.spec.js
@@ -1,4 +1,5 @@
 import { createLocalVue } from '~vue-test-utils'
+import Vue from 'vue'
 import Vuex from 'vuex'
 import Vuetify from 'vuetify'
 import VueRouter from 'vue-router'
@@ -113,6 +114,27 @@ describe('createLocalVue', () => {
     localVue.use(Vuetify)
   })
 
+  it('installs plugin into local Vue regardless of previous install in Vue', () => {
+    let installCount = 0
+
+    class Plugin {}
+    Plugin.install = function (_Vue) {
+      if (_Vue._installedPlugins) {
+        expect(_Vue._installedPlugins.indexOf(Plugin)).to.equal(-1)
+      }
+      installCount++
+    }
+
+    Vue.use(Plugin)
+    const localVue = createLocalVue()
+    localVue.use(Plugin)
+
+    if (localVue._installedPlugins) {
+      expect(localVue._installedPlugins.indexOf(Plugin)).to.equal(0)
+    }
+    expect(installCount).to.equal(2)
+  })
+
   it('has an errorHandler', () => {
     const localVue = createLocalVue()