find throws error when using refs

[unclejustin]

Version

1.0.0-beta.30

Reproduction link

https://gitlab.com/unclejustin/test-utils-but

Steps to reproduce

In a test reference an element by ref. Then try to find anything in that element using anything other than a dom selector:

const button = wrapper.find({ ref: "testButton" });
expect(button.find(Icon).exists()).toBe(true);

This will throw the errror "[vue-test-utils]: cannot find a Vue instance on a DOM node. The node you are calling find on does not exist in the VDom. Are you adding the node as innerHTML?"

What is expected?

That found elements have the same functionality as root wrappers.

What is actually happening?

Throwing an error.

---

I think this should work as described, but if I am wrong then maybe the docs just need to be updated to reflect the actual functionality?

[lmiller1990]

Without digging my guess is since you are using shallowMount, a stub is rendered instead of the actual component, which does not have the ref (maybe). My understanding is a ref is a static reference to a DOM element, and since the stub is a different component to the actual one with the ref, it isn't finding it.

What happens if you use mount?

[unclejustin]

Same issue. Sorry, I should have mentioned that I tried that already as well.

[unclejustin]

If it helps, here is where it is failing:

vue-test-utils/packages/test-utils/src/find.js

Line 58 in be4033e

if (root instanceof Element && selector.type !== DOM_SELECTOR) {

[dobromir-hristov]

Hey I think this is just a limitation of how you are chaining off find to a normal html component. We are kind of limited on how we can use find to search for components.
If you use a DOM selector instead of a Vue component, it should work.

The problem is, we cant find a Vue component by it's dom node, as that node could have a few components. And we cant search by Vue components, when we go down to DOM level :/

[unclejustin]

That's what I was seeing as well stepping through the code. It's cool, I'm going to try and work up a PR to make the docs more clear that this is a limitation.

[unclejustin]

PR here: #1481

[Stoom]

Can this be closed in lue of #1498 ?