-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
rename _h -> _c so that vue-template-es2015-compiler can use the new …
…internal createElement without breaking backwards compatibility
- Loading branch information
Showing
4 changed files
with
10 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4b51ad0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yyx990803 think this may have been a breaking change for packages. PeachScript/vue-infinite-loading#29 (comment) I'm also seeing the same error for other packages after upgrading.
4b51ad0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, unfortunately components that ship pre-compiled dist files need to re-compile with latest version of vue-template-compiler...
4b51ad0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do you ship a component without a pre-compiled dist file if you want to give the user the possibility to install it just with a
<script>
tag?4b51ad0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gurghet pre-compiled components can also be used with just a
<script>
tag. But if you really don't want to pre-compile, just keep the raw template string and let the user compile on the fly (this forces the user to use the standalone build).Still, this type of internal compilation changes are rare - we will also definitely be more careful to avoid such changes in the future.