fix: warn slot-scope when used as a prop

vuejs · Oct 4, 2017 · 8295f71 · 8295f71
1 parent dae173d
commit 8295f71
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/core/instance/state.js b/src/core/instance/state.js
@@ -18,6 +18,7 @@ import {
   bind,
   noop,
   hasOwn,
+  hyphenate,
   isReserved,
   handleError,
   nativeWatch,
@@ -84,9 +85,11 @@ function initProps (vm: Component, propsOptions: Object) {
     const value = validateProp(key, propsOptions, propsData, vm)
     /* istanbul ignore else */
     if (process.env.NODE_ENV !== 'production') {
-      if (isReservedAttribute(key) || config.isReservedAttr(key)) {
+      const hyphenatedKey = hyphenate(key)
+      if (isReservedAttribute(hyphenatedKey) ||
+          config.isReservedAttr(hyphenatedKey)) {
         warn(
-          `"${key}" is a reserved attribute and cannot be used as component prop.`,
+          `"${hyphenatedKey}" is a reserved attribute and cannot be used as component prop.`,
           vm
         )
       }

diff --git a/test/unit/features/options/props.spec.js b/test/unit/features/options/props.spec.js
@@ -501,7 +501,7 @@ describe('Options props', () => {
   })
 
   it('warn reserved props', () => {
-    const specialAttrs = ['key', 'ref', 'slot', 'is']
+    const specialAttrs = ['key', 'ref', 'slot', 'is', 'slot-scope']
     new Vue({
       props: specialAttrs
     })