Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animation on transition-group changes in position not working #6792

Closed
neuroactive opened this issue Oct 13, 2017 · 2 comments · Fixed by #6796
Closed

Animation on transition-group changes in position not working #6792

neuroactive opened this issue Oct 13, 2017 · 2 comments · Fixed by #6796

Comments

@neuroactive
Copy link

Version

2.5.0

Reproduction link

https://jsfiddle.net/b2cxLdtb/

Steps to reproduce

See the jsfiddle link.

What is expected?

After clicking on an "Up" or "Down" link in the "Actions" column, the row should change position with the adjacent row using an animation taking 2 seconds.

What is actually happening?

The row changes position, but it is immediate.


This was working in 2.4.4.

@jkzing
Copy link
Member

jkzing commented Oct 13, 2017

This is some how related to the upgraded rollup build system. I did revert the build system changes and run dev build, it worked. (see: https://github.com/jkzing/vue/tree/revert-upgrade)

Not sure which dev dependency causes this, still needs further investigation.

Here is the new build file: https://raw.githubusercontent.com/jkzing/vue/revert-upgrade/dist/vue.js

@jkzing
Copy link
Member

jkzing commented Oct 13, 2017

Well, it its caused by rollup@0.50.0. Let's see https://github.com/vuejs/vue/compare/dev...jkzing:revert-upgrade?expand=1#diff-2025d2ea48e750bcd6bafe7ce824a851L8066, line 8069 and 8070 are removed by rollup during tree shaking, which is used to reflow document.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants