Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

$once does accept an array of events as the first parameter, but the vue.d.ts doesn't #8983

Closed
yikuo123 opened this issue Oct 24, 2018 · 0 comments · Fixed by #8995
Closed

$once does accept an array of events as the first parameter, but the vue.d.ts doesn't #8983

yikuo123 opened this issue Oct 24, 2018 · 0 comments · Fixed by #8995

Comments

@yikuo123
Copy link

Version

2.5.17

Reproduction link

https://github.com/vuejs/vue/blob/dev/types/vue.d.ts#L56

Steps to reproduce

edit the code in an editor

What is expected?

the editor prompt correctly

What is actually happening?

there is a warning：Argument type string[] is not assignable to parameter type string
@yikuo123 yikuo123 changed the title $once does accept an array of events as the first parameters, but the vue.d.ts doesn't $once does accept an array of events as the first parameter, but the vue.d.ts doesn't Oct 24, 2018
ant1m4tt3r pushed a commit to ant1m4tt3r/vue that referenced this issue Oct 26, 2018
fix(ts types): Fixing $once type declaration on vue.d.ts file. $once …
6c49169 
…should accept an event or array

Fixing $once type declaration on vue.d.ts file. $once should accept an event or array of events as
first paramete

fix vuejs#8983
@ant1m4tt3r ant1m4tt3r mentioned this issue Oct 26, 2018
Merged
13 tasks
yyx990803 pushed a commit that referenced this issue Dec 1, 2018
@ant1m4tt3r @yyx990803
fix(types): fix vm.$once argument type (#8995)
97086f3 
vm.$once should accept an event or array of events as first parameter.

fix #8983
f2009 pushed a commit to f2009/vue that referenced this issue Jan 25, 2019
@ant1m4tt3r
fix(types): fix vm.$once argument type (vuejs#8995)
8ced9c2 
vm.$once should accept an event or array of events as first parameter.

fix vuejs#8983
aJean pushed a commit to aJean/vue that referenced this issue Aug 19, 2020
@ant1m4tt3r @aJean
fix(types): fix vm.$once argument type (vuejs#8995)
40d8ed6 
vm.$once should accept an event or array of events as first parameter.

fix vuejs#8983
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ts types): Issue # 8983 Fixing $once type declaration on vue.d.ts file. $once … ant1m4tt3r/vue
1 participant
@yikuo123