Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ts types): Issue # 8983 Fixing $once type declaration on vue.d.ts file. $once … #8995

Merged
merged 1 commit into from
Dec 1, 2018

Conversation

ant1m4tt3r
Copy link
Contributor

@ant1m4tt3r ant1m4tt3r commented Oct 26, 2018

Issue #8983
$once should accept an event or array

Fixing $once type declaration on vue.d.ts file. $once should accept an event or array of events as
first parameter

fix #8983

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

…should accept an event or array

Fixing $once type declaration on vue.d.ts file. $once should accept an event or array of events as
first paramete

fix vuejs#8983
types/vue.d.ts Show resolved Hide resolved
@yyx990803 yyx990803 merged commit 97086f3 into vuejs:dev Dec 1, 2018
f2009 pushed a commit to f2009/vue that referenced this pull request Jan 25, 2019
vm.$once should accept an event or array of events as first parameter.

fix vuejs#8983
aJean pushed a commit to aJean/vue that referenced this pull request Aug 19, 2020
vm.$once should accept an event or array of events as first parameter.

fix vuejs#8983
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

$once does accept an array of events as the first parameter, but the vue.d.ts doesn't
5 participants