-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let userland remove the production tips info #4907
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the PR, but using I think it's better to just add a runtime config option. We will likely address this in the next release. |
Hi Evan. ( @yyx990803 ) Thanks for addressing the suggestion. I had a feeling I was skating on thin ice with this solution, but I didn't want to disrupt what seems to be a "no configuration" mantra of Vue too much and this was the only way I could figure it out. On that point, it seems to me, this mantra is what makes the warning necessary in the first place. There are certainly clear decisions that userland should make, one being setting up Vue for development or production and I think it is ok to allow that as a config setting. So, I request this not simply be a decision to remove the warning with an extra flag, but rather to have a clear setting for userland to setup Vue to run in "production" or "development" mode. This would negate the necessity of the warning altogether, because the situation "production" or "development" is then a userland responsibility and not a possible mistake of using Vue incorrectly. Scott P.S. don't forget to close the other PR in the Webpack Template. 😄 |
I loathe the fact Vue is the only package of 50+ I use that actually adds something like this to console. It's frustrating. |
@jaketoolson This has already been released: |
Thank you Vue team for taking my suggestion to heart and making it happen! 👍 Scott |
Somehow |
Made it work. Had to put it right after vue.js:
|
:8080/#/:6 Error parsing a meta element's content: ';' is not a valid key-value pair separator. Please use ',' instead. |
I am setting productionTip and devtools to false, but I'm still occasionally getting the messages printed in the console. Sometimes during testing too. It's really annoying. |
It's annoying me too |
|
To anyone coming here via search: This no longer works in Vue 3. |
I realized when using the prod version the Vue DevTools no longer work. Why was this removed in Vue 3? I find it really distracting to get this message on every single reload. |
AFAIK, and looking at a Vue 3 app, this warning is no longer there. 🤔 Scott |
Hi,
From the discussions here:
https://forum.vuejs.org/t/hide-notify-you-are-running-vue-in-development-mode/5661
and here:
aa6f7b4
and because it also annoys me, I decided to try and set up a flag, which will allow a dev to "consciously" remove the production tips info.
It is also related to (requires) this PR for the webpack template.
vuejs-templates/webpack#510
The flag is currently set to "false", so the client dev will have to go into the file and set it to true, to remove the production tips info.
If you let me know how to best document the availability of the flag (if the two PRs get accepted), I'd be also glad to add into about the flag to the docs too.
Also, this currently only works for the webpack setup. I haven't looked into the other build possibilities.
Scott