Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linkify option does not seem to work #1040

Closed
1 task done
octref opened this issue Nov 26, 2018 · 4 comments
Closed
1 task done

Linkify option does not seem to work #1040

octref opened this issue Nov 26, 2018 · 4 comments
Labels
type: enhancement Request to enhance an existing feature

Comments

@octref
Copy link
Member

octref commented Nov 26, 2018 •
edited
Loading

  • I confirm that this is a issue rather than a question.

Bug report

markdown.linkify do not linkify.

Version

  • 0.14.7
  • 1.0.0-alpha.24

Steps to reproduce

git clone git@github.com:vuejs/vetur.
git checkout linkify
vuepress dev docs
# Nagivate to http://localhost:8080/vetur/formatting and observe multiple pure links are not linkified

What is expected?

Links are linkified.

What is actually happening?

They aren't.

Other relevant information

  • Your OS: macOS High Sierra
  • Node.js version: v8.11.4
  • Browser version: Chrome latest
  • Is this a global or local install? Global
  • Which package manager did you use for the install? npm
@octref
Copy link
Member Author

octref commented Nov 26, 2018

Commit here: vuejs/vetur@401daa7

Related: vuejs/vetur#981

ulivz added a commit that referenced this issue Nov 26, 2018
@ulivz
feat($markdown): pass rest options to instantiate markdown-it
8383329 
Close: #1040

e.g.

  markdown: {
    config: md => {
      md.set({linkify: true});
    }
  }

shortcut:

  markdown: {
    linkify: true
  },
@ulivz
Copy link
Member

ulivz commented Nov 26, 2018

Thanks for the report! this looks like an issue but actually a necessary feature but we forgot in the past.

  • For 0.x, fixed at 8383329 at released at 0.14.8 ✨

  • For 1.x, will support this feature later.

@ulivz
Copy link
Member

ulivz commented Nov 26, 2018 •
edited
Loading

BTW, I found some bare HTML tags in your docs/CHANGELOG.md:

e.g. <template-component> and <version>, it's better to use use ` to wrap them.

@ulivz ulivz added the type: enhancement Request to enhance an existing feature label Nov 26, 2018
@octref
Copy link
Member Author

octref commented Nov 26, 2018

I see, that's why vuepress gives back scary warnings 😅 Thanks for the quick fix 👍

@ulivz ulivz closed this as completed in d8db81c Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement Request to enhance an existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@octref @ulivz