Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServiceWorker doesn't work #1271

Closed
1 task done
mysticatea opened this issue Feb 9, 2019 · 1 comment · Fixed by #1302
Closed
1 task done

ServiceWorker doesn't work #1271

mysticatea opened this issue Feb 9, 2019 · 1 comment · Fixed by #1302
Labels
type: bug Something isn't working

Comments

@mysticatea
Copy link
Member

  • I confirm that this is a issue rather than a question.

Bug report

Version

  • vuepress 1.0.0-alpha.37
  • @vuepress/plugin-pwa 1.0.0-alpha.0

Steps to reproduce

  1. Open https://mysticatea.github.io/eslint-plugin-eslint-comments/
  2. Open devtools' console
  3. You can find the following error message.
The path of the provided scope ('/') is not under the max scope allowed ('/eslint-plugin-eslint-comments/'). Adjust the scope, move the Service Worker script, or use the Service-Worker-Allowed HTTP header to allow the scope.

What is expected?

  • The site uses service worker.

What is actually happening?

  • The site fails to register service worker.

Other relevant information

  • Your OS: Travis CI's Linux container (Ubuntu 14.04.5 LTS)
  • Node.js version: 10.15.1
  • Browser version: Chrome 73.0.3683.27(Official Build)beta
  • Is this a global or local install? : local
  • Which package manager did you use for the install? : yarn

I guess that registrationOptions is lacking on @vuepress/plugin-pwa/lib/enhanceAppFile.js.

@ulivz
Copy link
Member

ulivz commented Feb 16, 2019

Could you help to review #1302

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants