Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need navbar to open/close sidebar #640

Open
ksacks opened this issue Jul 8, 2018 · 3 comments
Open

Need navbar to open/close sidebar #640

ksacks opened this issue Jul 8, 2018 · 3 comments
Labels
status: core team review Priority issues for the core team to review type: feature request Request to add a new feature

Comments

@ksacks
Copy link

ksacks commented Jul 8, 2018

Bug report

Version

0.11.0

Steps to reproduce

Using default theme :
1 - Set .vuepress/config.js to disable navbar

themeConfig: {
navbar : false
}

2 - Enable sidebar.
3 - Open on small width device
4 - There is no way to open/close sidebar because the toggle is in navbar. (except for touch swipe gesture)

What is expected?

Having a way to toggle sidebar even without navbar (in default theme).

What is actually happening?

No way of toggling sidebar without navbar (in default theme).

Other relevant information

  • Your OS: Kubuntu 18.04
  • Node.js version: 8.10.0
  • Browser version: Chromium 66.0.3359.181
  • Is this a global or local install? Global
  • Which package manager did you use for the install? Npm
@ulivz ulivz added the type: enhancement Request to enhance an existing feature label Jul 14, 2018
@MacZel
Copy link

MacZel commented Aug 6, 2018

Duplicate of #702

@MacZel
Copy link

MacZel commented Aug 23, 2018

#761

@bencodezen
Copy link
Member

@MacZel Thanks for your work on the initial proposal on this.

I could see how sidebar toggling could be useful when it comes to providing users the option to decide when they need the sidebar or not. I'll make sure to label this accordingly for the team to review.

@bencodezen bencodezen added type: feature request Request to add a new feature status: core team review Priority issues for the core team to review and removed type: enhancement Request to enhance an existing feature labels Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: core team review Priority issues for the core team to review type: feature request Request to add a new feature
Projects
None yet
Development

No branches or pull requests

4 participants