Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

themeConfig.serviceWorker.updatePopup only shows up on first page reload #677

Closed
jordonbaade opened this issue Jul 28, 2018 · 1 comment
Closed

Comments

@jordonbaade
Copy link
Contributor

@jordonbaade jordonbaade commented Jul 28, 2018

Bug report

When pushing new content to a VuePress site with the themeConfig.serviceWorker.updatePopup enabled the popup only shows up the first page reload - if you don't click the refresh button the popup no longer appears for subsequent page reloads.

Version

VuePress 0.13.0

Steps to reproduce

  1. Create a new commit
  2. Refresh the page to see the new content popup
  3. Refresh the page again and the new content popup doesn't appear

What is expected?

The service worker update popup should appear as long as there is a new service worker available.

What is actually happening?

The service worker update popup appears on refresh with new content but doesn't appear again if you refresh without clicking the update button.

Other relevant information

Your OS: macOS High Sierra v10.13.6
Node.js version: v9.1.0
Browser version: Version 68.0.3440.75 (Official Build) (64-bit)
Is this a global or local install? Global
Which package manager did you use for the install? Yarn

@ulivz
Copy link
Member

@ulivz ulivz commented Jul 28, 2018

yyx990803/register-service-worker#8

ulivz added a commit that referenced this issue Jul 31, 2018
@ulivz ulivz closed this as completed in 6d8f813 Aug 14, 2018
shaun554 added a commit to shaun554/vuepress that referenced this issue Mar 21, 2019
devs-cloud pushed a commit to devs-cloud/vue-dev that referenced this issue Dec 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants