Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: refine theme api #1319

Merged
merged 11 commits into from
Feb 26, 2019
Merged

feat: refine theme api #1319

merged 11 commits into from
Feb 26, 2019

Conversation

ulivz
Copy link
Member

@ulivz ulivz commented Feb 19, 2019 •
edited
Loading

Refer to docs and live deployed site.

@ulivz ulivz closed this Feb 19, 2019
@ulivz ulivz reopened this Feb 20, 2019
@ulivz ulivz closed this Feb 20, 2019
@ulivz ulivz reopened this Feb 20, 2019
@ulivz ulivz changed the title [WIP] feat: refine theme api feat: refine theme api Feb 24, 2019
@ulivz ulivz requested a review from shigma February 24, 2019 15:44
@ulivz ulivz added this to 2019-02 in 1.x Roadmap Feb 24, 2019
@ulivz ulivz removed this from 2019-02 in 1.x Roadmap Feb 24, 2019
shigma
shigma reviewed Feb 25, 2019
View reviewed changes
Copy link
Collaborator

@shigma shigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shigma shigma self-requested a review February 26, 2019 15:52
@ulivz ulivz merged commit d16d3d5 into master Feb 26, 2019
@ulivz ulivz deleted the feat/refine-theme-api branch March 4, 2019 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shigma shigma shigma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ulivz @shigma