Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update isExternal regex to comply with rfc3986 #1457

Closed
wants to merge 1 commit into from

Conversation

go2sh
Copy link

@go2sh go2sh commented Mar 17, 2019

Updates the regex to use the scheme specification from rfc3986.
This allows the user to use urls like spotify: or vscode: for special application usage.

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Updates the regex to use the scheme specification from rfc3986.
This allows the user to use urls like `spotify:` or `vscode:` for special application usage.
@flozero
Copy link
Collaborator

flozero commented Sep 5, 2019

hello @go2sh ! Thank's for your time and effort. Can you give us some example usage of that please ? Even if it look great we need maybe to update some part of the docs with that

@flozero flozero added complexity: easy Easy complexity effort: low Around a day or less status: awaiting more context Need more context about this issue topic: markdown Relates to VuePress markdown type: enhancement Request to enhance an existing feature version: 1.x Relates to version 1 of VuePress labels Sep 5, 2019
@go2sh
Copy link
Author

go2sh commented Sep 5, 2019

I use this in the index.md file:

actionText: Install Extension
actionLink: "vscode:extension/go2sh.cmake-integration"

I use vuepress as documentation generator for my visual studio code extension and I want to provide a link to directly install it in vscode. VSCode can register the schema "vscode" inside the browser and if so, vscode opens the referenced page.

@flozero
Copy link
Collaborator

flozero commented Sep 5, 2019

Ok can you resolve the conflict and give me the link of your github project i will have a look at it.

Thank's for your time !

@ulivz
Copy link
Member

ulivz commented Dec 20, 2021

Maybe this issue had been addressed at #1731

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity: easy Easy complexity effort: low Around a day or less status: awaiting more context Need more context about this issue topic: markdown Relates to VuePress markdown type: enhancement Request to enhance an existing feature version: 1.x Relates to version 1 of VuePress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants