Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix($plugin-pagination): get posts calculation error #1466

Closed
wants to merge 2 commits into from
Closed

fix($plugin-pagination): get posts calculation error #1466

wants to merge 2 commits into from

Conversation

lhz960904
Copy link
Contributor

Summary
This plugin enhanceAppFile calculation errors to get posts. When Max is 20 interval 10, it will slice [0, 11], [10, 21] ,but the right result should be [0, 10] [10, 20]

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@lhz960904 lhz960904 changed the title fix bug 【plugin-pagination】 fix($plugin-pagination): get posts calculation error Mar 20, 2019
@flozero
Copy link
Collaborator

flozero commented Sep 5, 2019

I will have a look of this pr. Maybe is more about the end calculation @lhz960904 ?

@flozero flozero added complexity: medium Medium complexity good first issue Good for newcomers status: core team assigned Core team member assigned topic: plugins Relates to VuePress plugins topic: theme Relates to VuePress theme type: bug Something isn't working version: 1.x Relates to version 1 of VuePress labels Sep 5, 2019
@kefranabg kefranabg removed the good first issue Good for newcomers label Sep 6, 2019
@flozero
Copy link
Collaborator

flozero commented Sep 7, 2019

@lhz960904 can you provide me a repo example please to validate a push the merge conflict resolve

@flozero flozero added the need feedback Awaiting author response label Sep 7, 2019
@flozero
Copy link
Collaborator

flozero commented Sep 7, 2019

#1345 relation with that pr too

@lhz960904
Copy link
Contributor Author

@lhz960904 can you provide me a repo example please to validate a push the merge conflict resolve
emm, this pr happened long long ago, at that time , there is not merge conflict . so now I don't know how to resolve . sorry

@flozero
Copy link
Collaborator

flozero commented Sep 9, 2019

just git pull origin master and resolve from here

@ulivz
Copy link
Member

ulivz commented Sep 23, 2019

This pagination plugin has been deprecated and merged into blog plugin, you can move this pull request to here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity: medium Medium complexity need feedback Awaiting author response status: core team assigned Core team member assigned topic: plugins Relates to VuePress plugins topic: theme Relates to VuePress theme type: bug Something isn't working version: 1.x Relates to version 1 of VuePress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants