-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add npm install
#1826
fix: Add npm install
#1826
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BronsonQuick nice catch!
As we saw with @kefranabg it's just for docs no need of package-lock my bad |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think npm install
is the default install script and you don't need to specify it.
https://docs.travis-ci.com/user/languages/javascript-with-nodejs/#what-this-guide-covers
https://dev.to/hankchanocd/comment/5i5b
Nevertheless the install command should be placed in the install
section of the Travis config.
install:
- npm install
script:
- npm run docs:build
Also keep in mind that npm ci
might be a better solution: https://docs.travis-ci.com/user/languages/javascript-with-nodejs/#npm-ci-support
Hey @BronsonQuick, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚 |
thank you all for the work. @adrianjost i agree with you we should iterate on your comment. Can you create a pr to update it ? |
Summary
The Travis script is missing
npm install
which means Travis will show:What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx]
, where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information: