Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat($theme-default): markdown details custom block (close #768) #2044

Merged
merged 2 commits into from
Nov 29, 2019

Conversation

meteorlxy
Copy link
Member

@meteorlxy meteorlxy commented Nov 28, 2019

Summary

Close #768

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

image
image

@ulivz ulivz merged commit 7f2a997 into vuejs:master Nov 29, 2019
@meteorlxy meteorlxy deleted the feat/details branch November 29, 2019 02:54
@vue-bot
Copy link

vue-bot commented Nov 29, 2019

Hey @meteorlxy, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚

@crimx
Copy link
Contributor

crimx commented Jan 26, 2020

It seems like this feature is still not published to npm?

@haoranpb
Copy link
Contributor

@crimx well..., yes. There has been a discussion lately in #2144 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request] Detailed Explanation
5 participants