Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation README.md and installation.md review #768

Merged
merged 1 commit into from
May 9, 2017
Merged

Conversation

MachinisteWeb
Copy link
Contributor

@MachinisteWeb MachinisteWeb commented May 9, 2017

We are the Vue-FR team. We provide our review on Vuex translation part (with cross consistency from others Vue documentations).

Fell free, if you prefer, to accept this pull request when all (or a lot of) pages will be translated but this pull request will help others translators to not done the translation twice.

French review:

  • Review of README.md done.
  • Review of installation.md done.

Process:

  • We will track all futur modification from en directory because in our working branch we use the en directory to work. All futur en modification at an already translated position will warns us with a conflict.
  • We reverse all work done from :working/en to :dev/fr and we will provide some pull request each time a set of pages will be translated.

Signed-off-by: Bruno Lesieur <bruno.lesieur@gmail.com>
@MachinisteWeb MachinisteWeb changed the title [Official] French translation update from Vue-FR [Translation] Official French Translation Review from Vue-FR May 9, 2017
@MachinisteWeb MachinisteWeb changed the title [Translation] Official French Translation Review from Vue-FR [Translation] Official French Translation from Vue-FR May 9, 2017
@posva
Copy link
Member

posva commented May 9, 2017

Don't merge yet, please

@haeresis tu penses rajouter des commit au fur et à mesure ou pas ?

@MachinisteWeb
Copy link
Contributor Author

MachinisteWeb commented May 9, 2017

Hi @posva

Chaque fois qu'un document est traduit, revu et validé par au moins 2 relecteurs, cette pull request sera mise à jour, et j'ajouterai les éléments dans le résumé de la pull request.

Si vous la validez, les utilisateurs de la documentation auront les pages au fur et à mesure qu'elles sont revues en FR sachant qu'une autre pull request arrivera au prochain fichier traduit.

Si vous souhaitez ne pas valider, car vous estimez qu'une relecture « complète » est nécessaire avant merge vous pouvez garder cette pull request (de notre côté aucune pull request ne bloque notre travail). Cela permet « d'informer » sur l'état de notre travail (pour pas le faire à double).


Each time a document is translated, reviewed and validated by 2 contributors, this pull request will be update, and I update the topic with a resume of new modification for this pull request.

If you validate, users of documentation will have access soon to the FR review. An other review will be proposed next time a file will be reviewed.

If you prefer do not validate this because you prefer « complete » review before merge you can kept this PR here (that not block our process of translation/review). That allows others « to know » the work status (to not done work twice)

@posva
Copy link
Member

posva commented May 9, 2017

Ok, pour nous, c'est plus optimal d'avoir des PR avec un peu plus de modifs d'un coup, mais si elles arrivent comme ça, ça marche aussi 🙂

@posva posva merged commit 1344e73 into vuejs:dev May 9, 2017
@MachinisteWeb MachinisteWeb changed the title [Translation] Official French Translation from Vue-FR Documentation README.md and installation.md review May 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants