fix(pwa2): fix default slot warning

vuepress-theme-hope · Mar 5, 2022 · d6d1071 · d6d1071
1 parent 02fef19
commit d6d1071
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 8 deletions.
diff --git a/packages/pwa2/src/client/global-components/SWUpdatePopup.ts b/packages/pwa2/src/client/global-components/SWUpdatePopup.ts
@@ -20,7 +20,7 @@ export default defineComponent({
     const reload = (): void => {
       if (registration.value) {
         useSkipWaiting(registration.value);
-        location.reload();
+        window.location.reload();
 
         registration.value = null;
       }
@@ -40,16 +40,16 @@ export default defineComponent({
       h(
         Transition,
         { name: "popup" },
-        slots.default?.({
-          enabled: enabled.value,
-          reload,
-        }) ||
+        () =>
+          slots.default?.({
+            enabled: enabled.value,
+            reload,
+          }) ||
           (enabled.value
             ? h(
-                "div",
+                "button",
                 {
                   class: "sw-update-popup",
-                  role: "button",
                   tabindex: 0,
                   onClick: () => reload(),
                 },
@@ -58,7 +58,7 @@ export default defineComponent({
                   h("span", { class: "update" }, h(UpdateIcon)),
                 ]
               )
-            : "")
+            : null)
       );
   },
 });
diff --git a/packages/pwa2/src/client/styles/popup.scss b/packages/pwa2/src/client/styles/popup.scss
@@ -28,6 +28,7 @@
   right: 1rem;
   bottom: 1rem;
   padding: 0.5rem 0.75rem;
+  border-width: 0;
   border-radius: 0.5rem;
   box-shadow: 0 2px 12px 0 var(--card-shadow);
   background: var(--c-bg, #fff);