-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(markdown): remove codePlugin and add vPrePlugin (close #1550) #1556
Conversation
Pull Request Test Coverage Report for Build 9185430779Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Co-authored-by: 张怀文 <mister-hope@outlook.com>
I think you can remove code Plugin entirely in this PR. |
markdown.code
, migrate to the ecosystem
@meteorlxy Test is added, this should be ready. |
if (code !== false) { | ||
md.use<CodePluginOptions>(codePlugin, code) | ||
if (code) { | ||
logger.warn( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have we updated the docs? Or maybe we need to link to plugin docs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I will open a pr for this, note a route related pr is open a few days ago not not being merged.
#1556) BREAKING CHANGE: `markdown.code` option is remove. Please use `@vuepress/plugin-shiki` and `@vuepress/plugin-prismjs` instead. -------------- Co-authored-by: 张怀文 <mister-hope@outlook.com> Co-authored-by: meteorlxy <meteor.lxy@foxmail.com>
Before submitting the PR, please make sure you do the following
close #123
).What is the purpose of this pull request?
Description
See #1550 .
Related PRs:
codePlugin
from@vuepress/markdown
toplugin-shiki
andplugin-prismjs
ecosystem#137