Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: country state on billing step not getting persisted upon selection #194

Merged
merged 2 commits into from
Apr 21, 2022
Merged

fix: country state on billing step not getting persisted upon selection #194

merged 2 commits into from
Apr 21, 2022

Conversation

nentor
Copy link
Contributor

@nentor nentor commented Apr 15, 2022 •
edited
Loading

Description

Fixes a bug where the state for the country select field on the checkout billing step does not change upon selection

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Baroshem
Baroshem reviewed Apr 19, 2022
View reviewed changes
Copy link
Collaborator

@Baroshem Baroshem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One request from me :)

packages/theme/pages/Checkout/Billing.vue Show resolved Hide resolved
@nentor nentor force-pushed the nentor-bug/billing-country branch from dad19c7 to 3225e2a Compare April 19, 2022 19:50
@nentor nentor requested a review from Baroshem April 19, 2022 19:51
@nentor nentor force-pushed the nentor-bug/billing-country branch from 3225e2a to 2007f48 Compare April 19, 2022 19:53
@Baroshem
Copy link
Collaborator

Thanks @nentor !

@Baroshem Baroshem merged commit c32ca51 into vuestorefront-community:develop Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Baroshem Baroshem Baroshem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nentor @Baroshem