Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/cli tool #280

Merged
merged 21 commits into from
Jan 17, 2020
Merged

Feat/cli tool #280

merged 21 commits into from
Jan 17, 2020

Conversation

patzick
Copy link
Collaborator

@patzick patzick commented Jan 14, 2020

CLI package. Instruction for later put in README

To test it follow instructions in PWA setup section in CHEATSHEET.md file

Progress of this PR:

  • generate CLI project
  • init Nuxt project
  • update nuxt config
  • update nuxt plugins
  • add packages
  • prepare default files
  • add more info about what's currently going on
  • add config file with shopware instance info

In scope after this PR

  • download and put plugin files
  • prepare to publish CLI package
  • collect all TODOs from methods and put them into issues

@github-actions
Copy link

github-actions bot commented Jan 14, 2020

Deploy preview for website ready!

Built with commit 89038dd

https://shopware-pwa-p5ly78vzi.now.sh

@patzick patzick requested a review from mkucmus January 16, 2020 12:14
@patzick patzick marked this pull request as ready for review January 16, 2020 12:14
@patzick patzick requested a review from krskibin January 16, 2020 12:14
@patzick
Copy link
Collaborator Author

patzick commented Jan 17, 2020

First init run:
image

Second init run (and every other):
image

Running shopware-pwa dev:
image

Copy link
Collaborator

@mkucmus mkucmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's amazing how easily we can run the project! good job 👍

print: { info }
} = toolbox;

const name = parameters.first;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it generates undefined-model.ts if no filename provided

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, it's just a showcase command, I will remove it later so I haven't mentioned it in documentation :)

Copy link
Collaborator

@krskibin krskibin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLI works fine

@patzick patzick merged commit 960ed22 into master Jan 17, 2020
@patzick patzick deleted the feat/cli-tool branch January 17, 2020 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants