Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: navbar top simple mobile #2830

Merged
merged 3 commits into from
Jun 23, 2023
Merged

feat: navbar top simple mobile #2830

merged 3 commits into from
Jun 23, 2023

Conversation

justyna-13
Copy link
Contributor

@justyna-13 justyna-13 commented Jun 15, 2023 •
edited

Related issue

Closes # https://vsf.atlassian.net/jira/software/c/projects/SFUI2/boards/69?modal=detail&selectedIssue=SFUI2-1172&assignee=5fcf86fca1d3f100684db8a5

Scope of work

Blocks for navbar top with simple mobile bar

Screenshots of visual changes

Screenshot 2023-06-15 at 08 20 30 Screenshot 2023-06-15 at 08 20 19

Checklist

  • Self code-reviewed
  • Changes documented
  • Semantic HTML
  • SSR-friendly
  • Caching friendly
  • a11y for WCAG 2.0 AA
  • examples created
  • blocks created
  • cypress tests created

@changeset-bot
Copy link

changeset-bot bot commented Jun 15, 2023 •
edited

⚠️ No Changeset found

Latest commit: b7c44b6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@justyna-13 justyna-13 changed the title feat: navbar top with simple mobile feat: navbar top simple mobile Jun 15, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jun 15, 2023

[storefront-ui-react] Please retry analysis of this Pull-Request directly on SonarCloud.

@sonarcloud
Copy link

sonarcloud bot commented Jun 15, 2023

[storefront-ui-vue] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

1 similar comment
@sonarcloud
Copy link

sonarcloud bot commented Jun 15, 2023

[storefront-ui-vue] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@justyna-13 justyna-13 marked this pull request as ready for review June 15, 2023 09:58
@sonarcloud
Copy link

sonarcloud bot commented Jun 22, 2023

[storefront-ui-vue] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Jun 22, 2023

[storefront-ui-react] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@FRSgit FRSgit self-requested a review June 22, 2023 10:47
@justyna-13 justyna-13 merged commit e3c66d5 into v2-develop Jun 23, 2023
13 checks passed
@justyna-13 justyna-13 deleted the feat/navbar-for-mobile branch June 23, 2023 10:47
MaciejWolowski pushed a commit that referenced this pull request Jun 26, 2023
@justyna-13 @MaciejWolowski
feat: navbar top simple mobile (#2830)
d0999c3 
* feat: navbar top with simple mobile

* feat: navbar top with simple mobile

* fix: smaller iframe for navbars top
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRSgit FRSgit FRSgit approved these changes

@Szymon-dziewonski Szymon-dziewonski Awaiting requested review from Szymon-dziewonski Szymon-dziewonski is a code owner

@dkacper dkacper Awaiting requested review from dkacper

@mattmaribojoc mattmaribojoc Awaiting requested review from mattmaribojoc mattmaribojoc is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@justyna-13 @FRSgit