Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: binding on vue components [SV-222] #2988

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

Szymon-dziewonski
Copy link
Contributor

@Szymon-dziewonski Szymon-dziewonski commented Sep 26, 2023

Related issue

https://vsf.atlassian.net/browse/SV-222

Scope of work

Some components had wrong placement of v-bind, because of that user would not be able to overwrite some initial attributes, such as data-testid

Screenshots of visual changes

Checklist

  • Self code-reviewed
  • Changes documented
  • Semantic HTML
  • SSR-friendly
  • Caching friendly
  • a11y for WCAG 2.0 AA
  • examples created
  • blocks created
  • cypress tests created

@changeset-bot
Copy link

changeset-bot bot commented Sep 26, 2023

🦋 Changeset detected

Latest commit: 4e48d99

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@storefront-ui/vue Patch
@storefront-ui/nuxt Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sonarcloud
Copy link

sonarcloud bot commented Sep 26, 2023

[storefront-ui-vue] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@sonarcloud
Copy link

sonarcloud bot commented Sep 26, 2023

[storefront-ui-react] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@Szymon-dziewonski Szymon-dziewonski merged commit fae7ba0 into v2-develop Sep 27, 2023
28 checks passed
@Szymon-dziewonski Szymon-dziewonski deleted the fix--all-data-test-id-inheritance branch September 27, 2023 08:03
Szymon-dziewonski added a commit that referenced this pull request Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants