Merge pull request #3218 from Cheeerd/#3164

fix configurable options label in cart after product just added
vuestorefront · Jul 11, 2019 · 5582a8d · 5582a8d
2 parents ac2f53f + fbb7c08
commit 5582a8d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -22,6 +22,7 @@ value); `final_price` might been used along with `special_price` with Magento fo
 - Make image proxy url work with relative base url - @cewald (#3158)
 - Fixed memory leak with enabled dynamicConfigReload - @dimasch (#3075)
 - Fixed error for the orderhistory null for google-tag-manager extension - @cnviradiya (#3195)
+- Fixed label of configurable options in cart after product just added - @cheeerd (#3164)
 
 ### Changed / Improved
 - Shipping address is saved as default when not logged in user chooses to create account during checkout - @iwonapiotrowska (#2636)

diff --git a/core/modules/catalog/helpers/index.ts b/core/modules/catalog/helpers/index.ts
@@ -377,13 +377,13 @@ export function setConfigurableProductOptionsAsync (context, { product, configur
           existingOption = {
             option_id: option.attribute_id,
             option_value: configOption.id,
-            label: i18n.t(configOption.attribute_code),
+            label: option.label || i18n.t(configOption.attribute_code),
             value: configOption.label
           }
           configurable_item_options.push(existingOption)
         }
         existingOption.option_value = configOption.id
-        existingOption.label = i18n.t(configOption.attribute_code)
+        existingOption.label = option.label || i18n.t(configOption.attribute_code)
         existingOption.value = configOption.label
       }
     }