Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microcart product options for just added product #3164

Closed
Cheeerd opened this issue Jul 1, 2019 · 2 comments
Closed

Microcart product options for just added product #3164

Cheeerd opened this issue Jul 1, 2019 · 2 comments
Labels
bug Bug reports P4: Nice to have Priority mark - it's nice to have
Milestone

Comments

@Cheeerd
Copy link
Contributor

Cheeerd commented Jul 1, 2019

When product is added to cart, "product.options" are printed instead of "product.totals.options" until totals are not loaded. And it seems that attribute code (lower first latter) is printed instead of attribute label.

Screenshot from https://demo.vuestorefront.io:
image

Maybe you should not omit configurable_options in cart/addItem action to be able to access option labels in microcart from there. Or should add labels to product.options.

@Cheeerd Cheeerd added the bug Bug reports label Jul 1, 2019
@pkarw pkarw added the P4: Nice to have Priority mark - it's nice to have label Jul 1, 2019
@pkarw
Copy link
Collaborator

pkarw commented Jul 3, 2019

That's for sure a good idea. It requires a change to be made in here: https://github.com/DivanteLtd/vue-storefront/blob/3d1d81c0e1aebfcdeda97ea7fec58b6d3ab8ef29/core/modules/catalog/helpers/index.ts#L385

Probably just a mapping to the product.configurable_options - there is already an option mapped: https://github.com/DivanteLtd/vue-storefront/blob/3d1d81c0e1aebfcdeda97ea7fec58b6d3ab8ef29/core/modules/catalog/helpers/index.ts#L365

So probably we need just to make use of the label property - as it wasn't there when this helper was created :)

@pkarw
Copy link
Collaborator

pkarw commented Jul 3, 2019

@Cheeerd would you like to take care of this one?

@patzick patzick added this to the 1.11.0-rc.1 milestone Jul 11, 2019
pkarw added a commit that referenced this issue Jul 11, 2019
fix configurable options label in cart after product just added
@pkarw pkarw closed this as completed Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports P4: Nice to have Priority mark - it's nice to have
Projects
None yet
Development

No branches or pull requests

3 participants