Skip to content

Commit

Permalink
refactor(core): merge core packages (#358)
Browse files Browse the repository at this point in the history
* move

* update core

* update deps

* update after merge

* replace paths

* final touches

* update tests

* hotfix

* fix test

* fix

* update tsconfig

* merge core

* update travis cache

* merge

Co-authored-by: andrzejewsky <vox3r69@gmail.com>
  • Loading branch information
filrak and andrzejewsky committed Apr 14, 2020
1 parent e498a18 commit aa0ddd0
Show file tree
Hide file tree
Showing 111 changed files with 3,004 additions and 1,184 deletions.
8 changes: 2 additions & 6 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,8 @@ cache:
- packages/about-you/api-client/lib
- packages/about-you/composables/node_modules
- packages/about-you/composables/lib
- packages/core/utils/node_modules
- packages/core/utils/lib
- packages/core/factories/node_modules
- packages/core/factories/lib
- packages/core/interfaces/node_modules
- packages/core/interfaces/lib
- packages/core/core/node_modules
- packages/core/core/lib
- packages/prismic/node_modules
- packages/prismic/lib

Expand Down
6 changes: 2 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,7 @@
"scripts": {
"build:docs": "cd packages/core/docs && yarn build",
"dev:docs": "cd packages/core/docs && yarn dev",
"build:core:interfaces": "cd packages/core/interfaces && tsc",
"build:core:utils": "cd packages/core/utils && yarn build",
"build:core:factories": "cd packages/core/factories && yarn build",
"build:core": "yarn build:core:interfaces && yarn build:core:utils && yarn build:core:factories",
"build:core": "cd packages/core/core && yarn build",
"build:prismic": "cd packages/prismic && yarn build",
"build:ay:api-client": "cd packages/about-you/api-client && yarn build",
"build:ay:composables": "cd packages/about-you/composables && yarn build",
Expand Down Expand Up @@ -75,6 +72,7 @@
"packages/commercetools/*",
"packages/boilerplate/*",
"packages/core/*",
"packages/core/core",
"packages/prismic",
"packages/about-you/*"
],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ jest.mock('@vue-storefront/about-you-api', () => ({
Promise.resolve({})
}));

jest.mock('@vue-storefront/factories', () => ({
jest.mock('@vue-storefront/core', () => ({
useCategoryFactory: jest.fn(() => () => ({ foo: 'bar' }))
}));

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import useProduct from '../../../src/composables/useProduct';
import { mapProductSearch } from '../../../src/helpers';

jest.mock('@vue-storefront/about-you-api');
jest.mock('@vue-storefront/factories', () => ({
jest.mock('@vue-storefront/core', () => ({
useProductFactory: jest.fn(() => () => ({ foo: 'bar' }))
}));

Expand Down
2 changes: 1 addition & 1 deletion packages/about-you/composables/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"dependencies": {
"@vue-storefront/about-you-api": "^0.0.1",
"@vue/composition-api": "^0.3.4",
"@vue-storefront/factories": "^0.0.1",
"@vue-storefront/core": "^2.0.0",
"vue": "^2.6.x"
},
"devDependencies": {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/* istanbul ignore file */

import { CartGetters, AgnosticPrice, AgnosticTotals } from '@vue-storefront/interfaces';
import { CartGetters, AgnosticPrice, AgnosticTotals } from '@vue-storefront/core';
import { Cart, LineItem } from '@vue-storefront/boilerplate-api/src/types';

// eslint-disable-next-line @typescript-eslint/no-unused-vars
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/* istanbul ignore file */

import { CategoryGetters, AgnosticCategoryTree } from '@vue-storefront/interfaces';
import { CategoryGetters, AgnosticCategoryTree } from '@vue-storefront/core';
import { Category } from '@vue-storefront/boilerplate-api/src/types';

// eslint-disable-next-line @typescript-eslint/no-unused-vars
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/* istanbul ignore file */

import { CheckoutGetters} from '@vue-storefront/interfaces';
import { CheckoutGetters} from '@vue-storefront/core';
import { ShippingMethod } from '@vue-storefront/boilerplate-api/src/types';

// eslint-disable-next-line @typescript-eslint/no-unused-vars
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/* istanbul ignore file */

import { UserOrderGetters } from '@vue-storefront/interfaces';
import { UserOrderGetters } from '@vue-storefront/core';
import { BapiOrder } from '../../types';

// eslint-disable-next-line @typescript-eslint/no-unused-vars
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import {
AgnosticAttribute,
AgnosticPrice,
ProductGetters
} from '@vue-storefront/interfaces';
} from '@vue-storefront/core';
import { ProductVariant } from '@vue-storefront/boilerplate-api/src/types';

type ProductVariantFilters = any
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/* istanbul ignore file */

import { UserGetters} from '@vue-storefront/interfaces';
import { UserGetters} from '@vue-storefront/core';
import {BapiUser} from '../../types';

export const getUserFirstName = (user: BapiUser): string => user ? user.firstName : '';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/* istanbul ignore file */

import { UseCart } from '@vue-storefront/interfaces';
import { useCartFactory, UseCartFactoryParams } from '@vue-storefront/factories';
import { UseCart } from '@vue-storefront/core';
import { useCartFactory, UseCartFactoryParams } from '@vue-storefront/core';
import { ref, Ref } from '@vue/composition-api';
import { BapiCart, BapiCartItem, BapiCoupon, BapiProduct } from '../../types';

Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { getCategory } from '@vue-storefront/about-you-api';
import { useCategoryFactory } from '@vue-storefront/factories';
import { useCategoryFactory } from '@vue-storefront/core';
import { UseCategory, BapiCategory } from '../../types';

const useCategory: (id: string) => UseCategory<BapiCategory> = useCategoryFactory<BapiCategory, any>({
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/* istanbul ignore file */

import { UseCheckout } from '@vue-storefront/interfaces';
import { UseCheckout } from '@vue-storefront/core';
import { ref, Ref, computed } from '@vue/composition-api';
import { BapiUser, BapiShippingMethod, BapiUserAddress } from '../../types';

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/* istanbul ignore file */

import { UseLocaleFactoryParams } from '@vue-storefront/factories';
import { UseLocaleFactoryParams } from '@vue-storefront/core';

import {
countries,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/* istanbul ignore file */

import { UseLocale } from '@vue-storefront/interfaces';
import { useLocaleFactory } from '@vue-storefront/factories';
import { UseLocale } from '@vue-storefront/core';
import { useLocaleFactory } from '@vue-storefront/core';

import { params } from './factoryParams';

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { useProductFactory } from '@vue-storefront/factories';
import { useProductFactory } from '@vue-storefront/core';
import { mapProductSearch } from '../../helpers';
import { UseProduct, BapiProduct } from '../../types';

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/* istanbul ignore file */

import { UseUserFactoryParams } from '@vue-storefront/factories';
import { UseUserFactoryParams } from '@vue-storefront/core';
import { BapiUser } from '../../types';

export const params: UseUserFactoryParams<BapiUser, any, any> = {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
/* istanbul ignore file */

import { UseUser } from '@vue-storefront/interfaces';
import { UseUser } from '@vue-storefront/core';
import { BapiUser } from '../../types';

import { params } from './factoryParams';
import { useUserFactory } from '@vue-storefront/factories';
import { useUserFactory } from '@vue-storefront/core';

// @todo useUser

Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
/* istanbul ignore file */

import { useUserOrdersFactory, UseUserOrdersFactoryParams } from '@vue-storefront/factories';
import { useUserOrdersFactory, UseUserOrdersFactoryParams } from '@vue-storefront/core';
import { BapiOrder, BapiOrderSearchParams } from '../../types';
import { SearchResult } from '@vue-storefront/interfaces';
import { SearchResult } from '@vue-storefront/core';

// @todo userOrders

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/* istanbul ignore file */

import { ComputedProperty, UseWishlist } from '@vue-storefront/interfaces';
import { ComputedProperty, UseWishlist } from '@vue-storefront/core';
import { computed, Ref, ref } from '@vue/composition-api';
import { BapiProduct, BapiWishlist, BapiWishlistProduct } from '../../types';

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
/* istanbul ignore file */

import { SearchResult } from '@vue-storefront/interfaces';
import { SearchResult } from '@vue-storefront/core';
import { getProduct } from '@vue-storefront/about-you-api';
import { BapiProduct } from '@aboutyou/backbone/types/BapiProduct';

Expand Down
4 changes: 2 additions & 2 deletions packages/about-you/composables/src/types/index.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { BapiCategory } from '@aboutyou/backbone/types/BapiCategory';
import { BapiProduct } from '@aboutyou/backbone/types/BapiProduct';
import { UseCategory } from '@vue-storefront/interfaces';
import { UseProduct } from '@vue-storefront/interfaces';
import { UseCategory } from '@vue-storefront/core';
import { UseProduct } from '@vue-storefront/core';

// @todo: replace with real BapiUser type when AYC publishes that part of api
type BapiUser = {
Expand Down
8 changes: 4 additions & 4 deletions packages/about-you/theme/nuxt.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,13 @@ export default {
useRawSource: {
dev: [
'@vue-storefront/about-you',
'@vue-storefront/utils',
'@vue-storefront/factories'
'@vue-storefront/core',
'@vue-storefront/core'
],
prod: [
'@vue-storefront/about-you',
'@vue-storefront/utils',
'@vue-storefront/factories'
'@vue-storefront/core',
'@vue-storefront/core'
]
}
}],
Expand Down
2 changes: 1 addition & 1 deletion packages/boilerplate/api-client/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"test": "jest"
},
"dependencies": {
"@vue-storefront/factories": "^0.0.1"
"@vue-storefront/core": "^2.0.0"
},
"files": [
"lib/**/*"
Expand Down
2 changes: 1 addition & 1 deletion packages/boilerplate/api-client/src/index.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import getProduct from './api/getProduct';
import { apiClientFactory } from '@vue-storefront/factories';
import { apiClientFactory } from '@vue-storefront/core';

const { setup, override } = apiClientFactory<any, any>();

Expand Down
2 changes: 1 addition & 1 deletion packages/boilerplate/composables/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
},
"dependencies": {
"@vue-storefront/boilerplate-api": "^0.0.1",
"@vue-storefront/interfaces": "^0.0.3",
"@vue-storefront/core": "^2.0.0",
"@vue/composition-api": "^0.3.4"
},
"files": [
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { CartGetters, AgnosticPrice, AgnosticTotals, AgnosticAttribute } from '@vue-storefront/interfaces';
import { CartGetters, AgnosticPrice, AgnosticTotals, AgnosticAttribute } from '@vue-storefront/core';
import { Cart, LineItem } from '@vue-storefront/boilerplate-api/src/types';

export const getCartItems = (cart: Cart): LineItem[] => [];
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { CategoryGetters, AgnosticCategoryTree } from '@vue-storefront/interfaces';
import { CategoryGetters, AgnosticCategoryTree } from '@vue-storefront/core';
import { Category } from '@vue-storefront/boilerplate-api/src/types';

export const getCategoryTree = (category: Category): AgnosticCategoryTree => {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { CheckoutGetters} from '@vue-storefront/interfaces';
import { CheckoutGetters} from '@vue-storefront/core';
import { ShippingMethod } from '@vue-storefront/boilerplate-api/src/types';

export const getShippingMethodId = (shippingMethod: ShippingMethod): string => '';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import {
AgnosticAttribute,
AgnosticPrice,
ProductGetters
} from '@vue-storefront/interfaces';
} from '@vue-storefront/core';
import { ProductVariant } from '@vue-storefront/boilerplate-api/src/types';

type ProductVariantFilters = any
Expand Down
2 changes: 1 addition & 1 deletion packages/boilerplate/composables/src/useCart/index.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/* eslint-disable no-unused-vars, @typescript-eslint/no-unused-vars */
import { UseCart } from '@vue-storefront/interfaces';
import { UseCart } from '@vue-storefront/core';
import { Ref, ref } from '@vue/composition-api';
import { Cart, ProductVariant } from '@vue-storefront/boilerplate-api/src/types';

Expand Down
2 changes: 1 addition & 1 deletion packages/boilerplate/composables/src/useCategory/index.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/* eslint-disable no-unused-vars, @typescript-eslint/no-unused-vars */
import { UseCategory } from '@vue-storefront/interfaces';
import { UseCategory } from '@vue-storefront/core';
import { ref, Ref } from '@vue/composition-api';
import { Category, CategoryFilter } from '@vue-storefront/boilerplate-api/src/types';

Expand Down
2 changes: 1 addition & 1 deletion packages/boilerplate/composables/src/useCheckout/index.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// import { UseCheckout } from '@vue-storefront/interfaces';
// import { UseCheckout } from '@vue-storefront/core';
// import { ref, Ref, watch } from '@vue/composition-api';

// export default function useCheckout (): UseCheckout<any, any, any, any, any, any, any, any> {
Expand Down
2 changes: 1 addition & 1 deletion packages/boilerplate/composables/src/useProduct/index.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { UseProduct } from '@vue-storefront/interfaces';
import { UseProduct } from '@vue-storefront/core';
import { ref, Ref } from '@vue/composition-api';
import { ProductVariant } from '@vue-storefront/boilerplate-api/src/types';

Expand Down
2 changes: 1 addition & 1 deletion packages/boilerplate/composables/src/useWishlist/index.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/* eslint-disable no-unused-vars, @typescript-eslint/no-unused-vars */
import { UseWishlist } from '@vue-storefront/interfaces';
import { UseWishlist } from '@vue-storefront/core';
import { Ref, ref, watch } from '@vue/composition-api';
import { Wishlist, ProductVariant } from '@vue-storefront/boilerplate-api/src/types';

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jest.mock('@vue-storefront/commercetools-api', () => ({
updateCartQuantity: jest.fn(() => ({ data: { cart: 'some cart' } }))
}));

jest.mock('@vue-storefront/factories', () => ({
jest.mock('@vue-storefront/core', () => ({
useCartFactory: (params) => () => params,
}));

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jest.mock('@vue-storefront/commercetools-api', () => ({
}))
}));

jest.mock('@vue-storefront/factories', () => ({
jest.mock('@vue-storefront/core', () => ({
useCategoryFactory: (params) => () => params
}));

Expand Down
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
jest.mock('@vue-storefront/factories', () => ({
jest.mock('@vue-storefront/core', () => ({
useLocaleFactory: jest.fn(() => () => ({locale: 'en'}))
}));

jest.mock('../../src/useLocale/factoryParams', () => ({
params: {}
}));

import { useLocaleFactory } from '@vue-storefront/factories';
import { useLocaleFactory } from '@vue-storefront/core';
import { params } from '../../src/useLocale/factoryParams';
import useLocale from '../../src/useLocale';
describe('[commercetools-composables] useLocale', () => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jest.mock('@vue-storefront/commercetools-api', () => ({

jest.mock('./../../src/helpers/internals/enhanceProduct', () => jest.fn((args) => args));

jest.mock('@vue-storefront/factories', () => ({
jest.mock('@vue-storefront/core', () => ({
useProductFactory: (params) => () => params
}));

Expand Down
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
jest.mock('@vue-storefront/factories', () => ({
jest.mock('@vue-storefront/core', () => ({
useUserFactory: jest.fn(() => () => ({user: 'api'}))
}));

jest.mock('../../src/useUser/factoryParams', () => ({
params: {}
}));

import { useUserFactory } from '@vue-storefront/factories';
import { useUserFactory } from '@vue-storefront/core';
import { params } from '../../src/useUser/factoryParams';
import useUser from '../../src/useUser';
describe('[commercetools-composables] useUser', () => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jest.mock('@vue-storefront/commercetools-api', () => ({
}))
}));

jest.mock('@vue-storefront/factories', () => ({
jest.mock('@vue-storefront/core', () => ({
useUserOrdersFactory: (params) => () => params
}));

Expand Down
4 changes: 1 addition & 3 deletions packages/commercetools/composables/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,7 @@
},
"dependencies": {
"@vue-storefront/commercetools-api": "^0.0.3",
"@vue-storefront/factories": "^0.0.1",
"@vue-storefront/interfaces": "^0.0.3",
"@vue-storefront/utils": "^0.0.3",
"@vue-storefront/core": "^2.0.0",
"@vue/composition-api": "^0.3.4",
"js-cookie": "^2.2.1",
"vue": "^2.6.x"
Expand Down
Loading

0 comments on commit aa0ddd0

Please sign in to comment.