Skip to content

Commit

Permalink
Update packages to require Node 18 (#7157)
Browse files Browse the repository at this point in the history
* Bump all packages to require node.engines >= 18

* Move storefronts packages to main workspace

* Update yarn.lock

This installs @nuxt/ui-templates 1.3.4 which is MIT licensed (not CC-BY-ND-4.0)

* Force yarn to install peerDeps

* generate .nuxt folder that contains tsconfig.json

* Update test paths
  • Loading branch information
sethidden committed May 21, 2024
1 parent a1bdfc0 commit f06df9b
Show file tree
Hide file tree
Showing 107 changed files with 5,949 additions and 10,091 deletions.
17 changes: 17 additions & 0 deletions .changeset/dirty-rabbits-crash.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
---
"@vue-storefront/integrations-tsconfig": major
"@vue-storefront/api-extractor-config": major
"@vue-storefront/eslint-config-integrations": major
"@vue-storefront/prettier-config": major
"@vue-storefront/eslint-config": major
"@vue-storefront/rollup-config": major
"@vue-storefront/sdk-axios-request-sender": major
"@vue-storefront/jest-config": major
"@vue-storefront/changesets": major
"@vue-storefront/middleware": major
"@vue-storefront/multistore": major
"@vue-storefront/cli": major
"@vue-storefront/sdk": major
---

[CHANGED] Changed minimum Node version from 16 to 18. The condition that was forcing the Node version to be lower than 19 is also removed.
54 changes: 0 additions & 54 deletions .github/workflows/continuous-delivery-storefront.yml

This file was deleted.

74 changes: 0 additions & 74 deletions .github/workflows/continuous-integration-storefront.yml

This file was deleted.

3 changes: 3 additions & 0 deletions engineering-toolkit/api-extractor-config/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,5 +24,8 @@
],
"publishConfig": {
"access": "public"
},
"engines": {
"node": ">=18"
}
}
2 changes: 1 addition & 1 deletion engineering-toolkit/eslint-config/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
"access": "public"
},
"engines": {
"node": ">=16.0.0"
"node": ">=18"
},
"peerDependencies": {
"eslint": ">= 8"
Expand Down
3 changes: 3 additions & 0 deletions engineering-toolkit/integrations-eslint/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,5 +31,8 @@
"eslint-plugin-import": "^2.27.5",
"eslint-plugin-prettier": "^4.2.1",
"prettier": "^2.8.8"
},
"engines": {
"node": ">=18"
}
}
3 changes: 3 additions & 0 deletions engineering-toolkit/integrations-tsconfig/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,8 @@
],
"publishConfig": {
"access": "public"
},
"engines": {
"node": ">=18"
}
}
3 changes: 3 additions & 0 deletions engineering-toolkit/jest-config/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,5 +27,8 @@
},
"publishConfig": {
"access": "public"
},
"engines": {
"node": ">=18"
}
}
2 changes: 1 addition & 1 deletion engineering-toolkit/prettier-config/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,6 @@
"access": "public"
},
"engines": {
"node": ">=16.0.0"
"node": ">=18"
}
}
3 changes: 3 additions & 0 deletions engineering-toolkit/rollup-config/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,5 +36,8 @@
"@tsconfig/node16": "^1.0.4",
"rimraf": "^5.0.0",
"typescript": "^4.3"
},
"engines": {
"node": ">=18"
}
}
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"changesets:version": "yarn changeset version && YARN_ENABLE_IMMUTABLE_INSTALLS=false yarn install && yarn prepare:docs",
"changesets:publish": "yarn build && yarn changeset publish",
"prepare:docs": "cd docs && yarn install && yarn api-extract && yarn add-changelogs",
"postinstall": "cd packages/changesets && yarn build"
"postinstall": "cd packages/changesets && yarn build && cd ../../packages/nuxt && yarn run prepare"
},
"devDependencies": {
"@babel/core": "^7.10.5",
Expand Down
3 changes: 3 additions & 0 deletions packages/changesets/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,8 @@
"@types/jest": "^29.0.3",
"@types/node": "^18.11.17",
"ts-jest": "^29.0.2"
},
"engines": {
"node": ">=18"
}
}
2 changes: 1 addition & 1 deletion packages/cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@
"prepublish": "yarn build"
},
"engines": {
"node": ">=14"
"node": ">=18"
},
"bugs": "https://github.com/vuestorefront/vue-storefront/issues",
"keywords": [
Expand Down
9 changes: 6 additions & 3 deletions packages/middleware/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,11 @@
"@types/cookie-parser": "^1.4.3",
"@types/cors": "^2.8.12",
"@types/express": "^4.17.13",
"supertest": "^6.3.3",
"@types/supertest": "^2.0.13"
"@types/supertest": "^2.0.13",
"supertest": "^6.3.3"
},
"packageManager": "yarn@1.22.10"
"packageManager": "yarn@1.22.10",
"engines": {
"node": ">=18"
}
}
2 changes: 1 addition & 1 deletion packages/multistore/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"lib"
],
"engines": {
"node": ">=16.0.0"
"node": ">=18"
},
"scripts": {
"build": "rimraf lib && rollup -c",
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,12 @@
"build:pages-router": "cd __tests__/apps/pages-router && yarn build",
"dev:app-router": "cd __tests__/apps/app-router && yarn dev",
"dev:pages-router": "cd __tests__/apps/pages-router && yarn dev",
"dev:middleware": "cd ../../shared/src/__tests__/middleware && yarn dev",
"dev:middleware": "cd ../shared/src/__tests__/middleware && yarn dev",
"lint": "eslint . --ext .ts",
"test:app-router": "start-server-and-test dev:middleware localhost:4000/test_integration/getSuccess dev:app-router localhost:3000 \"yarn test:e2e\"",
"test:pages-router": "start-server-and-test dev:middleware localhost:4000/test_integration/getSuccess dev:pages-router localhost:3000 \"yarn test:e2e\"",
"test": "yarn test:app-router && yarn test:pages-router",
"test:e2e": "cd ../../shared/ && yarn test:e2e",
"test:e2e": "cd ../shared/ && yarn test:e2e",
"test:unit": "vitest run"
},
"dependencies": {
Expand All @@ -51,11 +51,13 @@
"react-dom": "^18.2.0",
"start-server-and-test": "^2.0.3",
"tsup": "8.0.1",
"vitest": "^0.34.6"
"vitest": "^0.34.6",
"react": "^18.2.0",
"next": "^13.4.7 || ^14.0.0"
},
"peerDependencies": {
"next": "^13.4.7 || ^14.0.0",
"react": "^18.2.0"
"react": "^18.2.0",
"next": "^13.4.7 || ^14.0.0"
},
"engines": {
"npm": ">=8.0.0",
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"jsx": "react",
"lib": ["dom", "dom.iterable", "esnext"],
"paths": {
"@storefront/shared": ["../../shared"]
"@storefront/shared": ["../shared"]
}
},
"exclude": ["node_modules"],
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,10 @@
"build": "nuxt-module-build build && yarn build:app",
"build:app": "cd __tests__/app && yarn build",
"dev": "cd __tests__/app && yarn dev",
"dev:middleware": "cd ../../shared/src/__tests__/middleware && yarn dev",
"dev:middleware": "cd ../shared/src/__tests__/middleware && yarn dev",
"lint": "eslint --ext .vue,.js,.ts .",
"test": "start-server-and-test dev:middleware localhost:4000/test_integration/getSuccess dev localhost:3000/ssr \"yarn test:e2e\"",
"test:e2e": "cd ../../shared/ && yarn test:e2e",
"test:e2e": "cd ../shared/ && yarn test:e2e",
"test:watch": "vitest watch",
"prepare": "nuxi prepare"
},
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
2 changes: 1 addition & 1 deletion packages/sdk-axios-request-sender/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,6 @@
"axios": "^0.27.2"
},
"engines": {
"node": ">= 16.x <= 20"
"node": ">=18"
}
}
10 changes: 5 additions & 5 deletions packages/sdk/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,17 +22,17 @@
"devDependencies": {
"@types/jest": "^29.0.3",
"@types/node": "^18.11.17",
"@vue-storefront/middleware": "*",
"axios": "^1.6.7",
"babel-cli": "^6.26.0",
"babel-preset-node": "^5.1.1",
"isomorphic-fetch": "^3.0.0",
"nodemon": "^2.0.20",
"ts-jest": "^29.0.2",
"ts-node-dev": "^2.0.0",
"@vue-storefront/middleware": "*",
"isomorphic-fetch": "^3.0.0",
"axios": "^1.6.7"
"ts-node-dev": "^2.0.0"
},
"engines": {
"npm": ">=7.0.0",
"node": ">=16.0.0"
"node": ">=18"
}
}
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
17 changes: 0 additions & 17 deletions packages/storefront/README.md

This file was deleted.

30 changes: 0 additions & 30 deletions packages/storefront/package.json

This file was deleted.

Loading

0 comments on commit f06df9b

Please sign in to comment.