Test out if SSR works perfectly well #12
Assignees
Milestone
Comments
|
@pkarw have you tested it? |
|
Yes, I've tested it. It works just fine, but needs to be fine-tuned (another issue is for that) |
filrak
pushed a commit
that referenced
this issue
Jan 5, 2021
sethidden
added a commit
that referenced
this issue
Apr 23, 2024
* ci: build, lint and test on ci * ci: add release action * ci: cache coverage * ci: use inputs for sonarcloud * ci: use envs for inputs * ci: use env for inputs * ci: another try with inputs * ci: fix syntax * ci: add inputs * refactor: clean blank lines * ci: separate actions for sonarcloud * ci: fix separate actions for sonarcloud * ci: fix sonarcloud secrets * ci: add project name * ci: fix project name * ci: add ci name * ci: test structure * ci: download artifacts to root * ci: remove coverage * ci: collect coverage from integration tests * ci: prepare cd action * ci: use main * fix: input not required * fix: use enterprise flag as input * ci: remove publish script * don't install husky git hooks when releasing why would you do that? certain hooks like pre-commit (for the repos that still use the stupid `commitizen`) the release will outright fail * chore: don't use yarn built-in script because it doesn't shadow (#7) * don't create github releases when publishing changesets/action@v1 will try to create a GitHub release in the repo when publishing a new package version. changesets/action@v1 tries to publish the release using the entire contents of the CHANGELOG.md as release description. The changelog file is taken from the package folder that it's publishing. See here for the code: https://github.com/changesets/action/blob/main/src/run.ts#L66-L68 The max char limit of the release description is 125,000 characters. The problem is many of our packages actually have longer changelogs than 125,000. For example this one has 200k characters: https://github.com/vuestorefront/bigcommerce/blob/main/packages/api-client/CHANGELOG.md I admit Github releases would be very useful for e.g. registering the Slack-Github bot in a customer's channel to let them now a new package release had happened. Unfortunately, I can't really remove the changelog because it contains important historical information. For now, I'm disabling creation of github releases and waiting for changesets to implement truncation: changesets/action#174 (comment) * chore: add codeowners for PR notifications * allow publishing OSS packages (#12) * log in in open source packages too in open source packages, we often publish to NPM. To do that, we need to log in (so that changesets/actions know how to publish) * publish using NPM_TOKEN if not enterprise * re-enable creating gh releases see changesets/action#304 (comment) * stop linting pr title with conventional commits we use changesets now so it's not necessary * add abillity to inject environment variables for use by unified ci (#4) * feat: allow setting env var Sometimes, running `yarn test` can require env variables, e.g. in the case of integration test * ci: use alternative solution --------- Co-authored-by: Wojciech Sikora <35867383+WojtekTheWebDev@users.noreply.github.com> * BREAKING don't log into private repo if it's not necessary !! THIS WILL BREAK EXISTING REPOS !! Before this commit, the repos running the CI action had no choice but always log into our private NPM repo using NPM_USER and NPM_PASS secrets. If you didn't have those secrets, the CI would fail. The error that caused the failure was that "NPM_PASS" is not defined as a secret. Of course it's not, because there's no reason to log in to any NPM repository in a public package, since npmjs is public. After this commit, the CI action doesn't log in into verdaccio by default. For repos like magento2 which are public, and don't use private pacakges, this doesn't make sense. Especially now that we use NPM_RELEASE_TOKEN secret for releases (which allows you to publish without having to provide NPM_USER and NPM_PASS), passing NPM_USER and NPM_PASS for a public repo makes even less sense. --- The breaking change comes from the fact that in private GH repos where the CI workflow is reused without explicitly passing the param "enterprise: true" (it's not passed because this argument didn't exist before this commit), will now default to "enterprise: false". This will break our private GitHub repos that need to `npm install` private vsf packages to work. It will break because the CI NPM will not be logged in. * remove unused ENVIRONMENT_VARIABLES input I don't know how this got here, this is entirely unused * remove unused sonarcloud vars sonarcloud-related stuff lives in sonarcloud.yml now * NPM_* secrets are used only if enterprise = true, so should be optional * feat: add node versions matrix input --------- Co-authored-by: Wojciech Sikora <wsikora@vuestorefront.io> Co-authored-by: Artur Tagisow <5359825+sethidden@users.noreply.github.com> Co-authored-by: Wojciech Sikora <35867383+WojtekTheWebDev@users.noreply.github.com> Co-authored-by: Artur Tagisow <atagisow@vuestorefront.io> Co-authored-by: John Doe <john.doe@gmail.com>
sethidden
added a commit
that referenced
this issue
Apr 23, 2024
* ci: build, lint and test on ci * ci: add release action * ci: cache coverage * ci: use inputs for sonarcloud * ci: use envs for inputs * ci: use env for inputs * ci: another try with inputs * ci: fix syntax * ci: add inputs * refactor: clean blank lines * ci: separate actions for sonarcloud * ci: fix separate actions for sonarcloud * ci: fix sonarcloud secrets * ci: add project name * ci: fix project name * ci: add ci name * ci: test structure * ci: download artifacts to root * ci: remove coverage * ci: collect coverage from integration tests * ci: prepare cd action * ci: use main * fix: input not required * fix: use enterprise flag as input * ci: remove publish script * don't install husky git hooks when releasing why would you do that? certain hooks like pre-commit (for the repos that still use the stupid `commitizen`) the release will outright fail * chore: don't use yarn built-in script because it doesn't shadow (#7) * don't create github releases when publishing changesets/action@v1 will try to create a GitHub release in the repo when publishing a new package version. changesets/action@v1 tries to publish the release using the entire contents of the CHANGELOG.md as release description. The changelog file is taken from the package folder that it's publishing. See here for the code: https://github.com/changesets/action/blob/main/src/run.ts#L66-L68 The max char limit of the release description is 125,000 characters. The problem is many of our packages actually have longer changelogs than 125,000. For example this one has 200k characters: https://github.com/vuestorefront/bigcommerce/blob/main/packages/api-client/CHANGELOG.md I admit Github releases would be very useful for e.g. registering the Slack-Github bot in a customer's channel to let them now a new package release had happened. Unfortunately, I can't really remove the changelog because it contains important historical information. For now, I'm disabling creation of github releases and waiting for changesets to implement truncation: changesets/action#174 (comment) * chore: add codeowners for PR notifications * allow publishing OSS packages (#12) * log in in open source packages too in open source packages, we often publish to NPM. To do that, we need to log in (so that changesets/actions know how to publish) * publish using NPM_TOKEN if not enterprise * re-enable creating gh releases see changesets/action#304 (comment) * stop linting pr title with conventional commits we use changesets now so it's not necessary * add abillity to inject environment variables for use by unified ci (#4) * feat: allow setting env var Sometimes, running `yarn test` can require env variables, e.g. in the case of integration test * ci: use alternative solution --------- Co-authored-by: Wojciech Sikora <35867383+WojtekTheWebDev@users.noreply.github.com> * BREAKING don't log into private repo if it's not necessary !! THIS WILL BREAK EXISTING REPOS !! Before this commit, the repos running the CI action had no choice but always log into our private NPM repo using NPM_USER and NPM_PASS secrets. If you didn't have those secrets, the CI would fail. The error that caused the failure was that "NPM_PASS" is not defined as a secret. Of course it's not, because there's no reason to log in to any NPM repository in a public package, since npmjs is public. After this commit, the CI action doesn't log in into verdaccio by default. For repos like magento2 which are public, and don't use private pacakges, this doesn't make sense. Especially now that we use NPM_RELEASE_TOKEN secret for releases (which allows you to publish without having to provide NPM_USER and NPM_PASS), passing NPM_USER and NPM_PASS for a public repo makes even less sense. --- The breaking change comes from the fact that in private GH repos where the CI workflow is reused without explicitly passing the param "enterprise: true" (it's not passed because this argument didn't exist before this commit), will now default to "enterprise: false". This will break our private GitHub repos that need to `npm install` private vsf packages to work. It will break because the CI NPM will not be logged in. * remove unused ENVIRONMENT_VARIABLES input I don't know how this got here, this is entirely unused * remove unused sonarcloud vars sonarcloud-related stuff lives in sonarcloud.yml now * NPM_* secrets are used only if enterprise = true, so should be optional * feat: add node versions matrix input --------- Co-authored-by: Wojciech Sikora <wsikora@vuestorefront.io> Co-authored-by: Artur Tagisow <5359825+sethidden@users.noreply.github.com> Co-authored-by: Wojciech Sikora <35867383+WojtekTheWebDev@users.noreply.github.com> Co-authored-by: Artur Tagisow <atagisow@vuestorefront.io> Co-authored-by: John Doe <john.doe@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It hasn't been tested well since the project start -it should work
The text was updated successfully, but these errors were encountered: