404 page #7
Assignees
Labels
good first issue
Tasks that requires just basic understanding of Vue Storefront
Projects
Milestone
Comments
|
In case when URL does not match category name i added We can also make a global handler in some store to do the same. |
|
OK, so it's not bat but would be rather better to add real 404 - as we're doing SSR (Server Side Rendering) - can you add some Error404 page and redirect to this one in this case? And then close :) |
|
@pkarw yup i will ;) |
karolbzik
added
the
good first issue
|
Catch the design for the 404 page. I suggest adding links to a chat (activate the livechat or any other chat tool, I will create a separated task for integration with this kind of tool), contact page, search (open the sidebar widget) and displaying the list of products (bestsellers or recommendations). |
filrak
pushed a commit
that referenced
this issue
Oct 22, 2020
sethidden
pushed a commit
that referenced
this issue
Apr 5, 2024
* feat: add rollup config package * refactor: use ts * chore: update readme * chore: add prepublish
sethidden
pushed a commit
that referenced
this issue
Apr 5, 2024
* feat: add rollup config package * refactor: use ts * chore: update readme * chore: add prepublish
sethidden
pushed a commit
that referenced
this issue
Apr 18, 2024
sethidden
added a commit
that referenced
this issue
Apr 18, 2024
* chore: initial structure * docs: update README * docs: update README * docs: update README * fix: namespace * docs: update README * docs: update README * fix: un char * Update README.md * chore: depts update * chore: versions bump * chore: add repository page * chore: add vsf core middlware handling * docs: readme update * chore: ignores update * revert: lib * chore: editable value handling * chore: building image object * chore: version bump * chore: build clean script * chore: content items check is array * chore: version bump * fix(#7): conditional chaning removed for sb bridge, version bump * chore: npmignore update * docs: update README * chore: version bump * docs: update README * chore: added #TechForUkraine * Update README.md * Update README.md * chore(in-3875): storyblok package upgrade (#26) * chore: swap storyblok packages * chore: upgrade storyblok package * chore: update dev dependencies * chore: update husky * chore: deactivate sonar cloud check * chore: install engineering toolkit dependencies * fix: linting errors * chore: storyblok bridge file improvements * chore: changeset * chore: enable releases from master * chore: node-version file (#27) * ci: release (rc) (#28) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * chore: exit pre mode (#29) * ci: release (#30) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * alokai rebranding (#31) Co-authored-by: krystian wlodarski <kwlodarski@vuestorefront.io> * Add storyblok to root * conventional pr name is not necessary if we have changesets * remove labeler on legacy * run old ci on legacy branch * Run on all Node versions - don't die if Node 14 fails * eslint --fix * manual eslint fixes * remove labeler * simplify storyblok devdeps --------- Co-authored-by: lukasborawski <lukas.borawski@gmail.com> Co-authored-by: Filip Rakowski <f.rakowskI@hotmail.com> Co-authored-by: Heitor Ramon Ribeiro <heitor.ramon@gmail.com> Co-authored-by: Łukasz Śliwa <39009379+lsliwaradioluz@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Krystian Wlodarski <kryswlo95@gmail.com> Co-authored-by: krystian wlodarski <kwlodarski@vuestorefront.io>
sethidden
added a commit
that referenced
this issue
Apr 23, 2024
* ci: build, lint and test on ci * ci: add release action * ci: cache coverage * ci: use inputs for sonarcloud * ci: use envs for inputs * ci: use env for inputs * ci: another try with inputs * ci: fix syntax * ci: add inputs * refactor: clean blank lines * ci: separate actions for sonarcloud * ci: fix separate actions for sonarcloud * ci: fix sonarcloud secrets * ci: add project name * ci: fix project name * ci: add ci name * ci: test structure * ci: download artifacts to root * ci: remove coverage * ci: collect coverage from integration tests * ci: prepare cd action * ci: use main * fix: input not required * fix: use enterprise flag as input * ci: remove publish script * don't install husky git hooks when releasing why would you do that? certain hooks like pre-commit (for the repos that still use the stupid `commitizen`) the release will outright fail * chore: don't use yarn built-in script because it doesn't shadow (#7) * don't create github releases when publishing changesets/action@v1 will try to create a GitHub release in the repo when publishing a new package version. changesets/action@v1 tries to publish the release using the entire contents of the CHANGELOG.md as release description. The changelog file is taken from the package folder that it's publishing. See here for the code: https://github.com/changesets/action/blob/main/src/run.ts#L66-L68 The max char limit of the release description is 125,000 characters. The problem is many of our packages actually have longer changelogs than 125,000. For example this one has 200k characters: https://github.com/vuestorefront/bigcommerce/blob/main/packages/api-client/CHANGELOG.md I admit Github releases would be very useful for e.g. registering the Slack-Github bot in a customer's channel to let them now a new package release had happened. Unfortunately, I can't really remove the changelog because it contains important historical information. For now, I'm disabling creation of github releases and waiting for changesets to implement truncation: changesets/action#174 (comment) * chore: add codeowners for PR notifications * allow publishing OSS packages (#12) * log in in open source packages too in open source packages, we often publish to NPM. To do that, we need to log in (so that changesets/actions know how to publish) * publish using NPM_TOKEN if not enterprise * re-enable creating gh releases see changesets/action#304 (comment) * stop linting pr title with conventional commits we use changesets now so it's not necessary * add abillity to inject environment variables for use by unified ci (#4) * feat: allow setting env var Sometimes, running `yarn test` can require env variables, e.g. in the case of integration test * ci: use alternative solution --------- Co-authored-by: Wojciech Sikora <35867383+WojtekTheWebDev@users.noreply.github.com> * BREAKING don't log into private repo if it's not necessary !! THIS WILL BREAK EXISTING REPOS !! Before this commit, the repos running the CI action had no choice but always log into our private NPM repo using NPM_USER and NPM_PASS secrets. If you didn't have those secrets, the CI would fail. The error that caused the failure was that "NPM_PASS" is not defined as a secret. Of course it's not, because there's no reason to log in to any NPM repository in a public package, since npmjs is public. After this commit, the CI action doesn't log in into verdaccio by default. For repos like magento2 which are public, and don't use private pacakges, this doesn't make sense. Especially now that we use NPM_RELEASE_TOKEN secret for releases (which allows you to publish without having to provide NPM_USER and NPM_PASS), passing NPM_USER and NPM_PASS for a public repo makes even less sense. --- The breaking change comes from the fact that in private GH repos where the CI workflow is reused without explicitly passing the param "enterprise: true" (it's not passed because this argument didn't exist before this commit), will now default to "enterprise: false". This will break our private GitHub repos that need to `npm install` private vsf packages to work. It will break because the CI NPM will not be logged in. * remove unused ENVIRONMENT_VARIABLES input I don't know how this got here, this is entirely unused * remove unused sonarcloud vars sonarcloud-related stuff lives in sonarcloud.yml now * NPM_* secrets are used only if enterprise = true, so should be optional * feat: add node versions matrix input --------- Co-authored-by: Wojciech Sikora <wsikora@vuestorefront.io> Co-authored-by: Artur Tagisow <5359825+sethidden@users.noreply.github.com> Co-authored-by: Wojciech Sikora <35867383+WojtekTheWebDev@users.noreply.github.com> Co-authored-by: Artur Tagisow <atagisow@vuestorefront.io> Co-authored-by: John Doe <john.doe@gmail.com>
sethidden
added a commit
that referenced
this issue
Apr 23, 2024
* ci: build, lint and test on ci * ci: add release action * ci: cache coverage * ci: use inputs for sonarcloud * ci: use envs for inputs * ci: use env for inputs * ci: another try with inputs * ci: fix syntax * ci: add inputs * refactor: clean blank lines * ci: separate actions for sonarcloud * ci: fix separate actions for sonarcloud * ci: fix sonarcloud secrets * ci: add project name * ci: fix project name * ci: add ci name * ci: test structure * ci: download artifacts to root * ci: remove coverage * ci: collect coverage from integration tests * ci: prepare cd action * ci: use main * fix: input not required * fix: use enterprise flag as input * ci: remove publish script * don't install husky git hooks when releasing why would you do that? certain hooks like pre-commit (for the repos that still use the stupid `commitizen`) the release will outright fail * chore: don't use yarn built-in script because it doesn't shadow (#7) * don't create github releases when publishing changesets/action@v1 will try to create a GitHub release in the repo when publishing a new package version. changesets/action@v1 tries to publish the release using the entire contents of the CHANGELOG.md as release description. The changelog file is taken from the package folder that it's publishing. See here for the code: https://github.com/changesets/action/blob/main/src/run.ts#L66-L68 The max char limit of the release description is 125,000 characters. The problem is many of our packages actually have longer changelogs than 125,000. For example this one has 200k characters: https://github.com/vuestorefront/bigcommerce/blob/main/packages/api-client/CHANGELOG.md I admit Github releases would be very useful for e.g. registering the Slack-Github bot in a customer's channel to let them now a new package release had happened. Unfortunately, I can't really remove the changelog because it contains important historical information. For now, I'm disabling creation of github releases and waiting for changesets to implement truncation: changesets/action#174 (comment) * chore: add codeowners for PR notifications * allow publishing OSS packages (#12) * log in in open source packages too in open source packages, we often publish to NPM. To do that, we need to log in (so that changesets/actions know how to publish) * publish using NPM_TOKEN if not enterprise * re-enable creating gh releases see changesets/action#304 (comment) * stop linting pr title with conventional commits we use changesets now so it's not necessary * add abillity to inject environment variables for use by unified ci (#4) * feat: allow setting env var Sometimes, running `yarn test` can require env variables, e.g. in the case of integration test * ci: use alternative solution --------- Co-authored-by: Wojciech Sikora <35867383+WojtekTheWebDev@users.noreply.github.com> * BREAKING don't log into private repo if it's not necessary !! THIS WILL BREAK EXISTING REPOS !! Before this commit, the repos running the CI action had no choice but always log into our private NPM repo using NPM_USER and NPM_PASS secrets. If you didn't have those secrets, the CI would fail. The error that caused the failure was that "NPM_PASS" is not defined as a secret. Of course it's not, because there's no reason to log in to any NPM repository in a public package, since npmjs is public. After this commit, the CI action doesn't log in into verdaccio by default. For repos like magento2 which are public, and don't use private pacakges, this doesn't make sense. Especially now that we use NPM_RELEASE_TOKEN secret for releases (which allows you to publish without having to provide NPM_USER and NPM_PASS), passing NPM_USER and NPM_PASS for a public repo makes even less sense. --- The breaking change comes from the fact that in private GH repos where the CI workflow is reused without explicitly passing the param "enterprise: true" (it's not passed because this argument didn't exist before this commit), will now default to "enterprise: false". This will break our private GitHub repos that need to `npm install` private vsf packages to work. It will break because the CI NPM will not be logged in. * remove unused ENVIRONMENT_VARIABLES input I don't know how this got here, this is entirely unused * remove unused sonarcloud vars sonarcloud-related stuff lives in sonarcloud.yml now * NPM_* secrets are used only if enterprise = true, so should be optional * feat: add node versions matrix input --------- Co-authored-by: Wojciech Sikora <wsikora@vuestorefront.io> Co-authored-by: Artur Tagisow <5359825+sethidden@users.noreply.github.com> Co-authored-by: Wojciech Sikora <35867383+WojtekTheWebDev@users.noreply.github.com> Co-authored-by: Artur Tagisow <atagisow@vuestorefront.io> Co-authored-by: John Doe <john.doe@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
/src/pages/Category.vue:22 - right now it's the Exception thrown when specific category page doesn't exist; need to be fixed - with global exception handler and custom exception class OR simply showing 404
We need "no result's message" anyway - when ES return no results
@filrak
The text was updated successfully, but these errors were encountered: