Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minify html + css #2182

Closed
jorkvist opened this issue Jan 14, 2019 · 6 comments
Closed

Minify html + css #2182

jorkvist opened this issue Jan 14, 2019 · 6 comments
Assignees
Labels
3: Medium complexity feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can vs-hackathon Tasks for the Hackathon
Milestone

Comments

@jorkvist
Copy link

What is the motivation for adding / enhancing this feature?

The current index document is pretty long and just minify/compress the output of html and css in the document will save around 80% of the document size.

Can you complete this feature request by yourself?

NO

Additional information

Tested to paste the html document here: https://htmlcompressor.com/compressor/
And it gave a 88% saving when compressed.

@pkarw
Copy link
Collaborator

pkarw commented Jan 14, 2019

the simplest solution is to enable gzip in the proxy but we can also use some express.js proxy

@pkarw
Copy link
Collaborator

pkarw commented Jan 14, 2019

https://www.npmjs.com/package/express-minify

We should use it only in the production mode

@pkarw pkarw added the vs-hackathon Tasks for the Hackathon label Jan 14, 2019
@filrak
Copy link
Collaborator

filrak commented Jan 16, 2019

@patzick afaik you've done it?

@patzick
Copy link
Collaborator

patzick commented Jan 16, 2019

@filrak we we have less data now in html and css on SSR, but is still could be minified on server render output. I'll assign myself to to this

@pkarw
Copy link
Collaborator

pkarw commented Feb 10, 2019

Plus - gzip / brotli also as a Express.js middlewares as we discussed

@patzick patzick modified the milestones: 1.9.0-rc.1, 1.9.0 Mar 5, 2019
@pkarw pkarw modified the milestones: 1.9.0, 1.10.0-rc.1 Mar 18, 2019
@pkarw pkarw modified the milestones: 1.10.0-rc.1, Feature waitinglist Apr 4, 2019
@pkarw
Copy link
Collaborator

pkarw commented Sep 3, 2019

These middlewares should be available to disable/enable via config.server.enableOutputCompression, config.server.enableOutputMinify ...

We can also consider the Webpack plugin for static files (CSS) minimization

Please make sure this mechanism is supporting Output caching

@pkarw pkarw modified the milestones: Feature waitinglist, 2.0-rc Sep 3, 2019
@pkarw pkarw added feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can 3: Medium complexity labels Sep 3, 2019
@sandermangel sandermangel added this to Accepted Feature Requests in Issue Kanban Sep 6, 2019
@pkarw pkarw closed this as completed Sep 11, 2019
Issue Kanban automation moved this from Accepted Feature Requests to Done Sep 11, 2019
@pkarw pkarw modified the milestones: 2.0-rc, 1.11.0-rc.1 Sep 11, 2019
pkarw added a commit that referenced this issue Sep 16, 2019
Feature #2182 - output compression and minifier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Medium complexity feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can vs-hackathon Tasks for the Hackathon
Projects
No open projects
Issue Kanban
  
Done
Development

No branches or pull requests

4 participants