Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature #2182 - output compression and minifier #3532

Merged
merged 4 commits into from
Sep 16, 2019
Merged

Feature #2182 - output compression and minifier #3532

merged 4 commits into from
Sep 16, 2019

Conversation

pkarw
Copy link
Collaborator

@pkarw pkarw commented Sep 11, 2019

Related issues

closes #2182

  • HTML Minifier has been added, to enable it please switch the config.server.useHtmlMinifier - @pkarw (Minify html + css #2182)
  • Output compression module has been added; it's enabled by default on production builds; to disable it please switch the src/modules/serrver.ts configuration - @pkarw (Minify html + css #2182)

@pkarw
Copy link
Collaborator Author

pkarw commented Sep 11, 2019

@filrak the new server modules are pretty cool! Actually I've used it to enable compression; I couldn't use the server modules for enabling html-minifier as the middlewares are being executed too late in the flow; we can't then store the output in the Redis cache (when the cache is enabled) As we discussed it would be awesome to extend this mechanism by kind of output filters that hook into ssr-renderer

@pkarw pkarw added the QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. label Sep 11, 2019
@pkarw pkarw added this to the 1.11.0-rc.1 milestone Sep 11, 2019
@pkarw pkarw merged commit 2fa0488 into develop Sep 16, 2019
@patzick patzick deleted the feature/2182 branch September 16, 2019 08:52
@patzick patzick removed the QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. label Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants