Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort by on Safari #2642

Closed
pkarw opened this issue Mar 23, 2019 · 3 comments
Closed

Sort by on Safari #2642

pkarw opened this issue Mar 23, 2019 · 3 comments
Assignees
@PanMisza
Labels
1: Easy bug Bug reports P3: Normal Priority mark - normal priority QA approved on branch Testers will add this label after positive check on specific branch. vs-hackathon Tasks for the Hackathon
Milestone
1.9.0-rc.2

Comments

@pkarw
Copy link
Collaborator

pkarw commented Mar 23, 2019

Current behavior

The styling is broken
Screenshot 2019-03-23 11 09 04

Expected behavior

Steps to reproduce the issue

Repository

Can you handle fixing this bug by yourself?

Environment details

  • Browser:
  • OS:
  • Node:
  • Code Version:

Additional information
@pkarw pkarw added bug Bug reports P3: Normal Priority mark - normal priority 1: Easy labels Mar 23, 2019
@PanMisza PanMisza self-assigned this Mar 23, 2019
@pkarw pkarw added this to the 1.9.0-rc.2 milestone Mar 25, 2019
@patzick
Copy link
Collaborator

patzick commented Mar 25, 2019

@PanMisza how is going on with this one?
Please remember to create branch for this from release/1.9 branch:)

@pkarw pkarw added the vs-hackathon Tasks for the Hackathon label Mar 30, 2019
haukebri pushed a commit to haukebri/vue-storefront that referenced this issue Mar 30, 2019
Fix safari style for sort-by select
ad3471e 
Addresses vuestorefront#2642
@haukebri haukebri mentioned this issue Mar 30, 2019
Closed
5 tasks
@haukebri
Copy link

I just fixed that - it was just a missing style.

haukebri pushed a commit to haukebri/vue-storefront that referenced this issue Mar 30, 2019
Fix safari style for sort-by select
43d814f 
Addresses vuestorefront#2642
@haukebri haukebri mentioned this issue Mar 30, 2019
Merged
7 tasks
@patzick
Copy link
Collaborator

patzick commented Mar 31, 2019

Thanks @haukebri ! :)

@patzick patzick closed this as completed Mar 31, 2019
@patzick patzick added the QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. label Mar 31, 2019
@ArturDivante ArturDivante added QA approved on branch Testers will add this label after positive check on specific branch. and removed QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. labels Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PanMisza PanMisza

Labels
1: Easy bug Bug reports P3: Normal Priority mark - normal priority QA approved on branch Testers will add this label after positive check on specific branch. vs-hackathon Tasks for the Hackathon
Projects
None yet
Milestone
1.9.0-rc.2
Development

No branches or pull requests
5 participants
@pkarw @patzick @haukebri @PanMisza @ArturDivante