Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After logging in when placing an order, products previously added to the basket are automatically added to the current order #2749

Closed
2 of 6 tasks
GabiDivante opened this issue Apr 17, 2019 · 1 comment
Labels
3: Medium complexity feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can QA approved after merge Testers will add this label after positive check on merged changes vs-hackathon Tasks for the Hackathon
Milestone

Comments

@GabiDivante
Copy link
Collaborator

What is the motivation for adding / enhancing this feature?

Currently, a customer who:
-> added selected products to the basket,
-> went to checkout,
-> then logged in to his account (from the personal details step)
has automatically added to the current order, products that were previously in his basket (which he added to the cart during the previous visit).
The customer may purchase more products by mistake. To remove unwanted products, he must go back to the cart and then go back to the checkout again.

What are the acceptance criteria

  • When the customer logs in when placing an order - the products previously added to the cart are not added to his order.

Can you complete this feature request by yourself?

  • YES
  • NO

Which Release Cycle state this refers to? Info for developer.

Pick one option.

  • This is a normal feature request. This should be available on https://test.storefrontcloud.io and then after tests this can be added to next Vue Storefront version. In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
  • (Pick this option only if you're sure) This is an important improvement request for current Release Candidate version on https://next.storefrontcloud.io and should be placed in next RC version. In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
  • (Pick this option only if you're sure) This is a critical improvement request for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version. In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.
@GabiDivante GabiDivante added the feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can label Apr 17, 2019
@pkarw
Copy link
Collaborator

pkarw commented Apr 17, 2019

cart/serverPull shouldn’t be called after user logs in in the checkout (otherwise it should work as it is right now without changes)

@pkarw pkarw added 3: Medium complexity vs-hackathon Tasks for the Hackathon labels Apr 17, 2019
@pkarw pkarw closed this as completed Apr 27, 2019
pkarw added a commit that referenced this issue Apr 27, 2019
pkarw added a commit that referenced this issue Apr 27, 2019
@pkarw pkarw added this to the 1.10.0-rc.1 milestone Apr 27, 2019
pkarw added a commit that referenced this issue May 3, 2019
@GabiDivante GabiDivante added the QA approved after merge Testers will add this label after positive check on merged changes label May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Medium complexity feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can QA approved after merge Testers will add this label after positive check on merged changes vs-hackathon Tasks for the Hackathon
Projects
None yet
Development

No branches or pull requests

2 participants