Order ID displayed in 'My orders' identical to the order ID in Magento

[GabiDivante]

What is the motivation for adding / enhancing this feature?

Currently, order ID displayed in 'My orders' is different from order ID in Magento. It is confusing for the customer when he sees one order ID in 'My orders' and gets a different one in the email order confirmation from Magento.

What are the acceptance criteria

• Order ID displayed in My orders is the same as in Magento Orders list.

Can you complete this feature request by yourself?

• YES
• NO

Which Release Cycle state this refers to? Info for developer.

Pick one option.

• This is a normal feature request. This should be available on https://test.storefrontcloud.io and then after tests this can be added to next Vue Storefront version. In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
• (Pick this option only if you're sure) This is an important improvement request for current Release Candidate version on https://next.storefrontcloud.io and should be placed in next RC version. In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
• (Pick this option only if you're sure) This is a critical improvement request for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version. In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Additional information

[GabiDivante]

@mdesmet @pkarw we need to add the correct Order ID on the order summary page as well

[mdesmet]

HI Gabi, I mentioned that open issue on the fix indeed. I'll have a look at it tomorrrow, must be not too hard to fix.

[GabiDivante]

@mdesmet Great! Thank you :)

[pkarw]

@mdesmet please just change the orderData.entity_id to orderData.increment_id and You’re there

[mdesmet]

@pkarw : from what I remember it was more complicated, the magento api returns only the internal id (see o2m.js).

[pkarw]

You might be right...

[mdesmet]

I don't really have time now to solve it right now, working on another project but here is my analysis:

We would have to extend the magento2-rest-client with support for retrieving the order based on the increment id returned by the order creation endpoint. See this Stack exchange with the solution: https://magento.stackexchange.com/questions/210000/retrieve-entity-id-from-rest-api-using-order-id

Then we can call this api in the o2m.js and change the bakendOrderId to the correct order id.

[Flyingmana]

shouldnt this be more of a cosmetic then a functional change?
vue-storefront is intended to connect with different systems, and its common that an Order has an entity ID, but exposes a different ID to the customer, which often allows more flexibility.

So it may make sense, that vue-storefront adds a new property to differentiate between entity_id and shown order_id

[mdesmet]

I wish it was just a cosmetic change but the response from the order endpoint only returns the internal increment id, no other properties, so we have to get the external order id somewhere else. IMHO the analysis still stands.

[patzick]

Thanks @Flyingmana !

[GabiDivante]

@Flyingmana I'm testing this solution on the branch develop and still order id on the thankyou page is different than in my orders, can you check it?

[patzick]

i've spoken with Gabi, i merged that to separate branch to faster merge that huge abount of PRs, no worries here :)

[mdesmet]

@patzick: I meant to comment on this one, actually this change doesn't work as orderData.increment_id is not defined at that point. We have to fetch it from magento api. @Flyingmana is on it already.

[Flyingmana]

added this fetch via vuestorefront/vue-storefront-api#258

[alinadivante]

@Flyingmana could you look at this feature request #3082 ? :)